Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall if installed version is older or newer than new one #358

Merged
merged 6 commits into from
Dec 19, 2018
Merged

Uninstall if installed version is older or newer than new one #358

merged 6 commits into from
Dec 19, 2018

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Dec 18, 2018 •
edited
Loading

Alternative of #357

  • Uninstall if installed espresso server is older or newer than new espresso server
  • Install new espresso server if uninstall happened or not installed it
  • Make sure the installation by checking io.appium.espressoserver.test/androidx.test.runner.AndroidJUnitRunner <= early optimisation
    • Current master has been updated to androidx

@KazuCocoa KazuCocoa mentioned this pull request Dec 18, 2018
Closed
@KazuCocoa KazuCocoa changed the title Add install logic espresso Uninstall if installed version is older or newer than new one Dec 18, 2018
@KazuCocoa
Copy link
Member Author

mm, Failing tests were npm run test:server related.

@KazuCocoa
Copy link
Member Author

📝 Failing tests were installation timeout

@mykola-mokhnach mykola-mokhnach merged commit ef9beec into appium:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KazuCocoa @mykola-mokhnach