Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement swipe and click actions #372

Merged
merged 14 commits into from
Jan 21, 2019

Conversation

dpgraham
Copy link
Contributor

@dpgraham dpgraham commented Jan 15, 2019

  • Add Kotlin to build.gradle and start using .kt files. .kt and .java are interoperable, so no concern about using both simultaneously
  • Implement Click Action and Swipe Action
  • Swipe action adds to the already existing mobile: swipe mobile endpoint. Can now pass parameters {swiper, startCoordinates, endCoordinates, ...},
  • Click action adds a new mobile: clickAction mobile endpoint which takes parameters {element, tapper, coordinatesProvider, precisionDescriber, inputDevice, buttonState}
  • Added JUnit tests to test the parsers

@dpgraham
Copy link
Contributor Author

Fixes pushed

@@ -14,8 +16,7 @@ android {

buildTypes {
release {
minifyEnabled false
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
minifyEnabled true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why should we enable that? this setting might corrupt class names, so they will not be visible for reflection calls

@appium appium deleted a comment Jan 17, 2019
@appium appium deleted a comment Jan 17, 2019
@appium appium deleted a comment Jan 17, 2019
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
CI is not happy 😢 (adb installation...)

@dpgraham
Copy link
Contributor Author

That's right @KazuCocoa ... do you or @mykola-mokhnach have any ideas why that's happening? I'm going to dig into tomorrow to see what happened.

@mykola-mokhnach
Copy link
Contributor

@dpgraham Most likely because of Travis slowness. How about moving the tests to Azure CI? @SrinivasanTarget has already done this for java client and the performance is good:
appium/java-client#1081

}
repositories {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we repeat that in both scripts?

@dpgraham dpgraham force-pushed the dpgraham-general-swipe-and-click-actions branch from 6e2a1c5 to c62c122 Compare January 21, 2019 19:30
@dpgraham dpgraham force-pushed the dpgraham-general-swipe-and-click-actions branch from a6095cd to 38bed6e Compare January 21, 2019 21:25
@dpgraham dpgraham merged commit 932f5c4 into master Jan 21, 2019
@dpgraham dpgraham deleted the dpgraham-general-swipe-and-click-actions branch January 21, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants