Merge pull request #161 from KazuCocoa/fix-get-biometric

fix getting biometric

lib/simulator-xcode-9.js

@@ -286,6 +286,11 @@ class SimulatorXcode9 extends SimulatorXcode8 {
     `;
   }
 
+  /**
+   * Return proper biometric menu name object.
+   * @param {string} biometricName A key in BIOMETRICS like 'bundleId'
+   * @returns {object} Object in BIOMETRICS
+   */
   getBiometric (biometricName) {
     const {BIOMETRICS} = SimulatorXcode9;
     if (!BIOMETRICS[biometricName]) {
@@ -298,7 +303,7 @@ class SimulatorXcode9 extends SimulatorXcode8 {
    * Get the current state of a biometric (touch id, face id) enrollment.
    * @override
    */
-  async isBiometricEnrolled (biometricName=SimulatorXcode9.BIOMETRICS.touchId) {
+  async isBiometricEnrolled (biometricName = 'touchId') {
     const {menuName} = this.getBiometric(biometricName);
     const output = await this.executeUIClientScript(`
       tell application "System Events"
@@ -317,7 +322,7 @@ class SimulatorXcode9 extends SimulatorXcode8 {
    * Execute a special Apple script, which enrolls biometric (TouchId, FaceId) feature testing in Simulator UI client.
    * @override
    */
-  async enrollBiometric (isEnabled = true, biometricName=SimulatorXcode9.BIOMETRICS.touchId) {
+  async enrollBiometric (isEnabled = true, biometricName = 'touchId') {
     const {menuName} = this.getBiometric(biometricName);
     await this.executeUIClientScript(`
       tell application "System Events"

test/unit/simulator-xcode-9-specs.js

@@ -0,0 +1,36 @@
+// transpile:mocha
+
+import chai from 'chai';
+import chaiAsPromised from 'chai-as-promised';
+import SimulatorXcode9 from "../../lib/simulator-xcode-9";
+
+chai.should();
+chai.use(chaiAsPromised);
+
+const XCODE_VERSION_9 = {
+  versionString: '9.0',
+  versionFloat: 9.0,
+  major: 9,
+  minor: 0,
+  patch: undefined
+};
+
+describe('SimulatorXcode9', function () {
+  let simulatorXcode9;
+
+  beforeEach(function () {
+    simulatorXcode9 = new SimulatorXcode9('1234', XCODE_VERSION_9);
+  });
+
+  describe('getBiometric', function () {
+    it('return touch id object', async function () {
+      simulatorXcode9.getBiometric('touchId').should.eql({ menuName: 'Touch Id' });
+    });
+
+    it('raise an error since the argument does not exist in biometric', async function () {
+      (function () {
+        simulatorXcode9.getBiometric('no-touchId');
+      }).should.throw(Error, 'no-touchId is not a valid biometric. Use one of: ["touchId","faceId"]');
+    });
+  });
+});