fix: add ios 14 and above case #351
Conversation
| @@ -102,21 +104,37 @@ async function setAccess (bundleId, permissionsMapping) { | |||
| * @param {string} serviceName - the name of the service. Should be one of | |||
| * `SERVICES` keys. | |||
| * @param {string} simDataRoot - the path to Simulator `data` root | |||
| * @returns {string} - The current status: yes/no/unset | |||
| * @returns {string} - The current status: yes/no/unset/limited | |||
There was a problem hiding this comment.
the documentation in xcuitest-driver should be updated after this change is merged
| try { | ||
| // iOS 14+ | ||
| return await getAccessStatus( | ||
| [['0', STATUS.NO], ['2', STATUS.YES], ['3', STATUS.LIMITED]], |
There was a problem hiding this comment.
what does value of '1' mean?
There was a problem hiding this comment.
Tried to find, but I was not able to figure 1 out yet. At least it is not in YES|NO|limited|unset
There was a problem hiding this comment.
location=always|inuse|never|unset did not match as well
| [['0', STATUS.NO], ['2', STATUS.YES], ['3', STATUS.LIMITED]], | ||
| 'auth_value' | ||
| ); | ||
| } catch { |
There was a problem hiding this comment.
shall we catch some particular error?
There was a problem hiding this comment.
Hm, I was only aware of no auth_value for the allowed query. When both are wrong, I expect the allowed one query will raise an error, then users may know something to report it
## [5.0.5](v5.0.4...v5.0.5) (2023-01-09) ### Bug Fixes * add ios 14 and above case ([#351](#351)) ([de60d15](de60d15))
|
🎉 This PR is included in version 5.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR is to fix getAcccess for iOS 14+ after #350
https://github.com/wix/AppleSimulatorUtils/blob/5467857407da4653305af119b2486051664a4f97/applesimutils/applesimutils/SetServicePermission.m
Should handle iOS version, or probably try iOs 14's first then fallback to existing one if an exception occurs only