fix: isAppInstalled in lib/simulator-xcode-15.js #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
commented
Jul 21, 2023
Comment on lines
+21
to
+26
| const infoPlistPath = path.resolve(appRoot, 'Info.plist'); | ||
| if (!(await fs.exists(infoPlistPath))) { | ||
| return ''; | ||
| } | ||
| const {stdout} = await exec('/usr/libexec/PlistBuddy', [ | ||
| '-c', 'print CFBundleIdentifier', path.resolve(appRoot, 'Info.plist') | ||
| '-c', 'print CFBundleIdentifier', infoPlistPath |
There was a problem hiding this comment.
no info.plist app existed...
[XCUITestDriver@44d3 (567021d0)] {"stdout":"File Doesn't Exist, Will Create: /Library/Developer/CoreSimulator/Volumes/iOS_21A5277g/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.0.simruntime/Contents/Resources/RuntimeRoot/Applications/TVRemoteUIService.app/Info.plist\n","stderr":"Print: Entry, \"CFBundleIdentifier\", Does Not Exist\n","code":1}
[DevCon Factory] Releasing connections for 63C676EB-2AFF-4EDB-8AD5-D9FD38A27DCB device on any port number
[DevCon Factory] No cached connections have been found
[debug] [XCUITestDriver@44d3 (567021d0)] Not clearing log files. Use `clearSystemFiles` capability to turn on.
[debug] [IOSSimulatorLog] Stopping iOS log capture
[debug] [XCUITestDriver@44d3 (567021d0)] Parsed BUILD_DIR configuration value: '/Users/kazu/Library/Developer/Xcode/DerivedData/WebDriverAgent-bowtbwjhvtmxajftyiaqrygoxash/Build/Products'
[debug] [XCUITestDriver@44d3 (567021d0)] Got derived data root: '/Users/kazu/Library/Developer/Xcode/DerivedData/WebDriverAgent-bowtbwjhvtmxajftyiaqrygoxash'
[debug] [AppiumDriver@d4a4] Event 'newSessionStarted' logged at 1689921783840 (23:43:03 GMT-0700 (Pacific Daylight Time))
[debug] [AppiumDriver@d4a4] Encountered internal error running command: Error: Command '/usr/libexec/PlistBuddy -c 'print CFBundleIdentifier' '/Library/Developer/CoreSimulator/Volumes/iOS_21A5277g/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.0.simruntime/Contents/Resources/RuntimeRoot/Applications/TVRemoteUIService.app/Info.plist'' exited with code 1
[debug] [AppiumDriver@d4a4] at ChildProcess.<anonymous> (/Users/kazu/.appium/node_modules/appium-xcuitest-driver/node_modules/teen_process/lib/exec.js:128:19)
[debug] [AppiumDriver@d4a4] at ChildProcess.emit (node:events:527:28)
[debug] [AppiumDriver@d4a4] at maybeClose (node:internal/child_process:1092:16)
[debug] [AppiumDriver@d4a4] at Socket.<anonymous> (node:internal/child_process:451:11)
[debug] [AppiumDriver@d4a4] at Socket.emit (node:events:527:28)
[debug] [AppiumDriver@d4a4] at Pipe.<anonymous> (node:net:709:12)
KazuCocoa
changed the title
|
Let's merge this for now to fix user-facing issue. Please change/comment when you come back from vacation @mykola-mokhnach |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
## [5.1.2](v5.1.1...v5.1.2) (2023-07-21) ### Bug Fixes * isAppInstalled in lib/simulator-xcode-15.js ([#368](#368)) ([8a749d1](8a749d1))
|
🎉 This PR is included in version 5.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to appium/appium#18749 (comment) , probably
await this.simctl.getEnv('IPHONE_SIMULATOR_ROOT')included a new line. Then, the built path could have\n.It might be safe to do
trim()