Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

feat: Allow to configure host/port/app path for Appium for mac app in appium-mac-driver #42

Merged
merged 7 commits into from
Jan 19, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
make port/host configuable
  • Loading branch information
KazuCocoa committed Jan 1, 2020
commit 87f661eea460847241b92c3c337c9a6ff8f12010
6 changes: 3 additions & 3 deletions lib/appium-for-mac.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ const REQ_A4M_APP_PATH = path.resolve('/Applications', 'AppiumForMac.app');
const a4mLog = logger.getLogger('Appium4Mac');

class AppiumForMac {
constructor () {
this.proxyHost = DEFAULT_A4M_HOST;
this.proxyPort = DEFAULT_A4M_PORT;
constructor (opts = {}) {
this.proxyHost = opts.a4mHost || DEFAULT_A4M_HOST;
this.proxyPort = opts.a4mPort || DEFAULT_A4M_PORT;
this.proc = null;
this.jwproxy = new JWProxy({server: this.proxyHost, port: this.proxyPort});
}
Expand Down
2 changes: 1 addition & 1 deletion lib/driver.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class MacDriver extends BaseDriver {
}

async startAppiumForMacSession () {
this.a4mDriver = new AppiumForMac();
this.a4mDriver = new AppiumForMac(this.ops);

await this.a4mDriver.start();
await this.a4mDriver.startSession(this.caps);
Expand Down