fix: enable console logging on page after navigating #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -172,7 +172,9 @@ class RemoteDebugger extends events.EventEmitter { | |||
| } | |||
|
|
|||
| async disconnect () { | |||
| await this.rpcClient.disconnect(); | |||
| if (this.rpcClient) { | |||
| await this.rpcClient.disconnect(); | |||
There was a problem hiding this comment.
should we also set this.rpcClient to null?
There was a problem hiding this comment.
That happens in the teardown function, called later in this function.
mykola-mokhnach
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without re-enabling console logging, the events only come if we are connected to a local server.
Fixes appium/appium#13431