-
Notifications
You must be signed in to change notification settings - Fork 180
Comparing changes
Open a pull request
base repository: apple/servicetalk
base: 0.42.48
head repository: apple/servicetalk
compare: main
- 9 commits
- 238 files changed
- 5 contributors
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f40d432 - Browse repository at this point
Copy the full SHA f40d432View commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 253d14f - Browse repository at this point
Copy the full SHA 253d14fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 338e52e - Browse repository at this point
Copy the full SHA 338e52eView commit details -
concurrent-api: save the timestamp of the SingleToFuture.get() calls (#…
…3051) Motivation: It can be very difficult to know if a thread is slow or completely stuck without taking multiple thread dumps and comparing them. Modifications: Try to mitigate this by saving the time stamp of the last blocking `.get()` call. This should then show up in heap dumps and we can at least compare them to see if they've all started blocking at about the same time or if there is a big spread. The latter would suggest they are truly stuck.
Configuration menu - View commit details
-
Copy full SHA for 249efc7 - Browse repository at this point
Copy the full SHA 249efc7View commit details
Commits on Sep 9, 2024
-
Stop using
servicetalk-dependencies
internally (#3055)Motivation: Gradle interprets `*.module` files differently than the `pom.xml`. Because every module currently depends on `servicetalk-dependencies`, users pulled its `dependencyConstraints` in their build configurations with any servicetalk module as transitive dependency and got unintended changes for other dependencies. For example, `servicetalk-annotations` that has only jsr305 as a 3-party dependency still forces upgrade of jackson, protobuf, log4j, netty, and jersey for users because it depends on `servicetalk-dependencies`. Modifications: - Remove `servicetalk-dependencies` from every module, instead define every necessary dependency by its version number or import only required boms; - Update `servicetalk-dependencies` to include missed dependencies: opentelemetry, instrumentation, resilience4j; - Correct dependencies for all `-jersery3` modules to keep only what they use; - Move all `platform` dependencies from the top to their corresponding scope; - Regenerate lock files; Result: Users don't get unintended dependency upgrades because of the `*.module` file handling.
Configuration menu - View commit details
-
Copy full SHA for 9e310cc - Browse repository at this point
Copy the full SHA 9e310ccView commit details
Commits on Sep 10, 2024
-
Make jsr305 api dependency for
servicetalk-annotations
(#3056)Motivation: It's exposed on `@ElementsAreNonnullByDefault` and therefore should be an `api` dependency instead of `implementation`. It will also help us to avoid adding `com.google.code.findbugs:jsr305` dependency for every module that already adds `servicetalk-annotations`. Modifications: - Change `api` to `implementation` for `com.google.code.findbugs:jsr305` in `servicetalk-annotations`; - Remove `com.google.code.findbugs:jsr305` from every module that already adds `servicetalk-annotations`; - Regenerate lock files;
Configuration menu - View commit details
-
Copy full SHA for f269b08 - Browse repository at this point
Copy the full SHA f269b08View commit details
Commits on Sep 17, 2024
-
loadbalancer-experimental: don't always pay for EWMA with noop detect…
…or (#3057) Motivation: There is a perf regression in the DefaultLB in compatibility mode compared to the round-robin LB when under very high request rate and that is at least in part attributable to lock contention for the health indicator EWMA. Modifications: Don't create a health indicator if the EWMA half life is 0.
Configuration menu - View commit details
-
Copy full SHA for 57f8454 - Browse repository at this point
Copy the full SHA 57f8454View commit details
Commits on Sep 19, 2024
-
HttpRequestMetaData#hasQueryParameter(String) implementaiton fix (#3058)
Motivation: HttpRequestMetaData#hasQueryParameter(String) returns false when there is a query parameter with no value. This is incorrect and it should return true.
Configuration menu - View commit details
-
Copy full SHA for 004983e - Browse repository at this point
Copy the full SHA 004983eView commit details
Commits on Sep 20, 2024
-
Allow null value for query parameter setter methods (#3059)
Motivation: 041f3dc replace empty string for null during parsing. However the setter/accessor methods don't consistently allow null values. Modifications: - Allow null values from add & set queryParameter methods.
Configuration menu - View commit details
-
Copy full SHA for 34a0849 - Browse repository at this point
Copy the full SHA 34a0849View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.42.48...main