Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apple/servicetalk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.42.48
Choose a base ref
...
head repository: apple/servicetalk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 9 commits
  • 238 files changed
  • 5 contributors

Commits on Aug 27, 2024

  1. Configuration menu
    Copy the full SHA
    f40d432 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    253d14f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    338e52e View commit details
    Browse the repository at this point in the history
  3. concurrent-api: save the timestamp of the SingleToFuture.get() calls (#…

    …3051)
    
    Motivation:
    
    It can be very difficult to know if a thread is slow or completely
    stuck without taking multiple thread dumps and comparing them.
    
    Modifications:
    
    Try to mitigate this by saving the time stamp of the last blocking
    `.get()` call. This should then show up in heap dumps and we can
    at least compare them to see if they've all started blocking at
    about the same time or if there is a big spread. The latter would
    suggest they are truly stuck.
    bryce-anderson committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    249efc7 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Stop using servicetalk-dependencies internally (#3055)

    Motivation:
    
    Gradle interprets `*.module` files differently than the `pom.xml`.
    Because every module currently depends on `servicetalk-dependencies`,
    users pulled its `dependencyConstraints` in their build configurations
    with any servicetalk module as transitive dependency and got unintended
    changes for other dependencies.
    
    For example, `servicetalk-annotations` that has only jsr305 as a 3-party
    dependency still forces upgrade of jackson, protobuf, log4j, netty, and
    jersey for users because it depends on `servicetalk-dependencies`.
    
    Modifications:
    
    - Remove `servicetalk-dependencies` from every module, instead define
    every necessary dependency by its version number or import only
    required boms;
    - Update `servicetalk-dependencies` to include missed dependencies:
    opentelemetry, instrumentation, resilience4j;
    - Correct dependencies for all `-jersery3` modules to keep only what
    they use;
    - Move all `platform` dependencies from the top to their corresponding
    scope;
    - Regenerate lock files;
    
    Result:
    
    Users don't get unintended dependency upgrades because of the `*.module`
    file handling.
    idelpivnitskiy committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    9e310cc View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Make jsr305 api dependency for servicetalk-annotations (#3056)

    Motivation:
    
    It's exposed on `@ElementsAreNonnullByDefault` and therefore should be
    an `api` dependency instead of `implementation`. It will also help us
    to avoid adding `com.google.code.findbugs:jsr305` dependency for every
    module that already adds `servicetalk-annotations`.
    
    Modifications:
    
    - Change `api` to `implementation` for `com.google.code.findbugs:jsr305`
    in `servicetalk-annotations`;
    - Remove `com.google.code.findbugs:jsr305` from every module that
    already adds `servicetalk-annotations`;
    - Regenerate lock files;
    idelpivnitskiy committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f269b08 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. loadbalancer-experimental: don't always pay for EWMA with noop detect…

    …or (#3057)
    
    Motivation:
    
    There is a perf regression in the DefaultLB in compatibility mode compared to
    the round-robin LB when under very high request rate and that is at least in part
    attributable to lock contention for the health indicator EWMA.
    
    Modifications:
    
    Don't create a health indicator if the EWMA half life is 0.
    bryce-anderson committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    57f8454 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. HttpRequestMetaData#hasQueryParameter(String) implementaiton fix (#3058)

    Motivation:
    HttpRequestMetaData#hasQueryParameter(String) returns false when there is
    a query parameter with no value. This is incorrect and it should return true.
    Scottmitch committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    004983e View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Allow null value for query parameter setter methods (#3059)

    Motivation:
    041f3dc replace empty string for
    null during parsing. However the setter/accessor methods don't
    consistently allow null values.
    
    Modifications:
    - Allow null values from add & set queryParameter methods.
    Scottmitch committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    34a0849 View commit details
    Browse the repository at this point in the history
Loading