Make jsr305 api dependency for servicetalk-annotations
#3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It's exposed on `@ElementsAreNonnullByDefault` and therefore should be an `api` dependency instead of `implementation`. It will also help us to avoid adding `com.google.code.findbugs:jsr305` dependency for every module that already adds `servicetalk-annotations`. Modifications: - Change `api` to `implementation` for `com.google.code.findbugs:jsr305` in `servicetalk-annotations`; - Remove `com.google.code.findbugs:jsr305` from every module that already adds `servicetalk-annotations`; - Regenerate lock files;
idelpivnitskiy
force-pushed
the
jsr305
branch
from
e6b19d6
to
0671005
Compare
daschl
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's exposed on
@ElementsAreNonnullByDefaultand therefore should be anapidependency instead ofimplementation. It will also help us to avoid addingcom.google.code.findbugs:jsr305dependency for every module that already addsservicetalk-annotations.Modifications:
apitoimplementationforcom.google.code.findbugs:jsr305inservicetalk-annotations;com.google.code.findbugs:jsr305from every module that already addsservicetalk-annotations;