Support Completable from a Callable #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkountis
changed the title
idelpivnitskiy
approved these changes
May 23, 2022
bondolo
reviewed
May 23, 2022
| } | ||
|
|
||
| @Override | ||
| public Completable closeAsyncGracefully() { | ||
| return blockingToCompletable(original::closeGracefully); | ||
| return Completable.fromCallable(() -> { |
There was a problem hiding this comment.
Why not use fromRunnable here and you could continue to use a method reference?
There was a problem hiding this comment.
We are trying to replace the internal class here with a public one to minimize API surface and allow reusability of some utility classes without the need to open up dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
New
Completableadapter from aCallableimplementation.Modification
New API to support this adaptor along with modification on the pre-existing
fromRunnableto re-use this newCallableapproach and minimize duplication.Result
Richer API