Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadbalancer-experimental: adjust load balancer policy docs and helpers #2926

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix style checks
  • Loading branch information
bryce-anderson committed May 14, 2024
commit 1b9a4892582f77f3cccb2042895f745c60c23cf8
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
* @param <ResolvedAddress> the type of the resolved address.
* @param <C> the type of the load balanced connection.
* @see <a href="https://www.eecs.harvard.edu/~michaelm/postscripts/tpds2001.pdf">Mitzenmacher (2001) The Power of Two
* * Choices in Randomized Load Balancing</a>
* Choices in Randomized Load Balancing</a>
* @deprecated Use {@link P2CLoadBalancingPolicyBuilder}.
*/
@Deprecated // FIXME: 0.42.45 - make package private
public final class P2CLoadBalancingPolicy<ResolvedAddress, C extends LoadBalancedConnection>
Expand Down Expand Up @@ -75,6 +76,7 @@ public String toString() {

/**
* A builder for immutable {@link P2CLoadBalancingPolicy} instances.
* @deprecated Use {@link P2CLoadBalancingPolicyBuilder}.
*/
@Deprecated // FIXME: 0.42.45 - remove builder.
public static final class Builder {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,24 @@
/*
* Copyright © 2024 Apple Inc. and the ServiceTalk project authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.servicetalk.loadbalancer;

import io.servicetalk.client.api.LoadBalancedConnection;

import javax.annotation.Nullable;
import java.util.Random;
import javax.annotation.Nullable;

import static io.servicetalk.utils.internal.NumberUtils.ensurePositive;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
*
* @param <ResolvedAddress> the type of the resolved address
* @param <C> the type of the load balanced connection
* @deprecated Use {@link RoundRobinLoadBalancingPolicyBuilder}.
*/
@Deprecated // FIXME: 0.42.45 - make package private
public final class RoundRobinLoadBalancingPolicy<ResolvedAddress, C extends LoadBalancedConnection>
Expand Down Expand Up @@ -59,6 +60,7 @@ public String toString() {

/**
* A builder for immutable {@link RoundRobinLoadBalancingPolicy} instances.
* @deprecated Use {@link RoundRobinLoadBalancingPolicyBuilder}.
*/
@Deprecated // FIXME: 0.42.45 - remove builder.
public static final class Builder {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
/*
* Copyright © 2024 Apple Inc. and the ServiceTalk project authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.servicetalk.loadbalancer;

import io.servicetalk.client.api.LoadBalancedConnection;
Expand Down
Loading