loadbalancer-experimental: add LB observer method for when the host set changes #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et changes Motivation: It can be valuable to know what the current host set is but we don't have a way to directly observer that right now. Modifications: Add a method to the LoadBalancerObserver that can capture when the host set changes and use it in DefaultLoadBalancer.
bryce-anderson
force-pushed
the
bl_anderson/host_set_changed_observer
branch
from
75eed92
to
bf3d1b9
Compare
bryce-anderson
requested review from
mgodave and
tkountis
and removed request for
mgodave
...ider/src/main/java/io/servicetalk/loadbalancer/experimental/DefaultLoadBalancerObserver.java
Outdated
Show resolved
Hide resolved
...loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/DefaultLoadBalancer.java
Outdated
Show resolved
Hide resolved
...loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/DefaultLoadBalancer.java
Show resolved
Hide resolved
...ider/src/main/java/io/servicetalk/loadbalancer/experimental/DefaultLoadBalancerObserver.java
Outdated
Show resolved
Hide resolved
| this.hostSelector = hostSelector.rebuildWithHosts(priorityStrategy.prioritize(usedHosts)); | ||
| nextHosts = priorityStrategy.prioritize(nextHosts); | ||
| this.hostSelector = hostSelector.rebuildWithHosts(nextHosts); | ||
| loadBalancerObserver.onHostSetChanged(Collections.unmodifiableCollection(nextHosts)); |
There was a problem hiding this comment.
After the 2nd look: priorityStrategy returns a List. Why does the observer provide a Collection? Just to align with SD discovery publisher contract? Will List be beneficial to signal Host priorities to users of LB-observer?
There was a problem hiding this comment.
We talked offline and the static type of Collection is fine and I've used the unmodifiableList method to make the dynamic type more helpful.
...loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/DefaultLoadBalancer.java
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It can be valuable to know what the current host set is but we don't have a way to directly observer that right now.
Modifications:
Add a method to the LoadBalancerObserver that can capture when the host set changes and use it in DefaultLoadBalancer.