Fix Typhoon.framework target #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperblues
added a commit
that referenced
this pull request
Sep 9, 2015
Fix Typhoon.framework target
|
Thanks @peterkutasi I'll create a new tag. |
|
Great work! @jasperblues Looks like we need some automated testing for framework target? (I run OSX and IOS test targets before pushing new version) |
|
@alexgarbarev Yes we do. This isn't the first time this has happened 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #411
Typhoon.framework target is broken because TyphoonInjectionDefinition is missing from the framework target.
This PR adds this class to the target.
I also extended the build.sh to build Typhoon.framework as well so these kind of issues will surface quickly.