Block definitions #475
Merged
Block definitions #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onDefinition+Internal
…TyphoonAssemblyDefinitionBuilder
…sembly & assembly definition builder
| @@ -30,4 +32,13 @@ - (id)anotherKnight | |||
| }]; | |||
| } | |||
|
|
|||
| - (id)blockKnight | |||
| { | |||
| return [TyphoonBlockDefinition withClass:[Knight class] block:^id{ | |||
There was a problem hiding this comment.
Is duplication of Knight class reference intentional? I mean, it's being used there and later in [[Knight alloc] init].
There was a problem hiding this comment.
Yes. We need to know the component type beforehand so Typhoon would be able to use this definition for auto-injections and injections by property type.
This was referenced Feb 8, 2016
|
Thank you @nickynick |
|
Congrats! A great feature! |
|
🎉 🍻 Thanks! I'll get on docs and stuff like that shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of an idea from #467. Please see
TyphoonBlockDefinitionfor details :) There is already a bunch of tests for this - not sure if that's enough, but it's something to begin with. I'll be adding some docs shortly.As a bonus, I also felt entitled to do some cleanup & reorganizing. In particular, all infrastructure-related stuff was moved from
Typhoon.humbrella header toTyphoon+Infrastructure.h. I feel like that's the way to go with all the stuff which is not intended for basic usage.