Implement MB Seconds function and builds metric #8235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PineappleIOnic
changed the title
app/init.php
Outdated
| const METRIC_FUNCTION_ID_BUILDS = '{functionInternalId}.builds'; | ||
| const METRIC_FUNCTION_ID_BUILDS_STORAGE = '{functionInternalId}.builds.storage'; | ||
| const METRIC_FUNCTION_ID_BUILDS_COMPUTE = '{functionInternalId}.builds.compute'; | ||
| const METRIC_FUNCTION_ID_DEPLOYMENTS = '{resourceType}.{resourceInternalId}.deployments'; | ||
| const METRIC_FUNCTION_ID_DEPLOYMENTS_STORAGE = '{resourceType}.{resourceInternalId}.deployments.storage'; | ||
| const METRIC_FUNCTION_ID_BUILDS_MB_SECONDS = '{functionInternalId}.builds.mb_seconds'; |
There was a problem hiding this comment.
We might also want
- METRIC_FUNCTION_ID_MB_SECONDS = '{functionInternalId}.mbSeconds'
for convenience, which would be a total of the build and execution mbSeconds for a specific function
There was a problem hiding this comment.
Doesn't METRIC_FUNCTION_ID_EXECUTIONS_MB_SECONDS cover that?
shimonewman
reviewed
Jun 10, 2024
shimonewman
reviewed
Jun 10, 2024
Co-authored-by: Christy Jacob <christyjacob4@gmail.com>
Co-authored-by: Shimon Newman <shimonewman@gmail.com>
Co-authored-by: Shimon Newman <shimonewman@gmail.com>
PineappleIOnic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements the metric that calculates GB Hours for functions and builds.
Checklist