Feature/ap 3948 #1072
Merged
Feature/ap 3948 #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I probably need to run through some parts of this PR |
raboczi
requested changes
Jul 8, 2021
There was a problem hiding this comment.
Goodness, there's a lot of work here.
I have a repetitive comment "Localize messagebox title" which would probably be most easily addressed by doing something similar to dashboard.util.ZKMessageCtrl or org.apromore.portal.common.notification.Notification and having some static utility methods.
...ore-Components/Apromore-Portal/src/main/java/org/apromore/portal/common/i18n/I18nConfig.java
Outdated
Show resolved
Hide resolved
...ore-Components/Apromore-Portal/src/main/java/org/apromore/portal/common/i18n/I18nConfig.java
Outdated
Show resolved
Hide resolved
...re-Components/Apromore-Portal/src/main/java/org/apromore/portal/common/i18n/I18nSession.java
Outdated
Show resolved
Hide resolved
...Apromore-Portal/src/main/java/org/apromore/portal/dialogController/BPMNEditorController.java
Outdated
Show resolved
Hide resolved
...promore-Portal/src/main/java/org/apromore/portal/dialogController/BaseListboxController.java
Show resolved
Hide resolved
...in-Portal-Plugin/src/main/java/org/apromore/plugin/portal/useradmin/UserAdminController.java
Outdated
Show resolved
Hide resolved
...in-Portal-Plugin/src/main/java/org/apromore/plugin/portal/useradmin/UserAdminController.java
Show resolved
Hide resolved
...in-Portal-Plugin/src/main/java/org/apromore/plugin/portal/useradmin/UserAdminController.java
Show resolved
Hide resolved
...-Admin-Portal-Plugin/src/main/java/org/apromore/plugin/portal/useradmin/UserAdminPlugin.java
Outdated
Show resolved
Hide resolved
...-Admin-Portal-Plugin/src/main/java/org/apromore/plugin/portal/useradmin/UserAdminPlugin.java
Outdated
Show resolved
Hide resolved
|
Reviewed and updated, except localization of Messagebox. Need to discuss how the static class defined in Core could pull resource bundle from various plugins. |
raboczi
approved these changes
Jul 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.