Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor3 #1121

Merged
merged 42 commits into from
Jul 27, 2021
Merged

Refactor3 #1121

merged 42 commits into from
Jul 27, 2021

Conversation

nolantellis
Copy link
Contributor

This is MErging Springboot with Dev. There are too many files. But all are just movements. Will walk through tomorrow in 30 min.

Nolan Tellis and others added 30 commits July 15, 2021 22:04
Add Spring boot support
53f2600
Merging Code in Springboot
ecf327c
Correction of some tests
6c02bb7
@Janite
Delete /SecurityUtilsTest.java
27ac2f3
@Janite
add enableEtl flag in application.yml
b9eeca4
@mayankgituni
fix: renamed the module with correct name in build file
1aca9c5
@justinapromore
null pointer issue fix
b0a340b
Minor chnages in integration test
d1e915c
Fix pd
32c3bbf
Minor fix
033725c
Added Keycloak support
ab372b7
Added login controller
d493697
@franklma
AP-2529 Refactor CSV Exporter to reduce memory footprint (#1107)
8a12001 
* AP-2529 Refactor CSV Exporter for better performance

* Further imporments

* rename and clean up

* clean up
Minor bug fix
3cef495
Merge branch 'refactor3' of github.com:apromore/ApromoreCore into ref…
c79edc7 
…actor3
Minor path change in js
8173ca0
minor chnages to log dir in application
c81d877
@mayanktomar20
fix: the css and impala error
16410c0
@mayanktomar20
fix: session issues
2e8a2f7
Minor fix in css and security
6d9f6eb
Merge branch 'refactor3' of github.com:apromore/ApromoreCore into ref…
d158cca 
…actor3
Appl yaml
cdda924
Changes in spring security
3ba1b6c
@Janite
fix: links in UserAdminController and username error message for crea…
162980c 
…ting user
@nolantellis
Merge pull request #1113 from apromore/bugfix/AP-4245/Fix-create-user…
d994fdd 
…-error-message

bugfix/AP-4245-Fix-create-user-error-message
@franklma
AP-4284 Save BPMN Model on Process Discoverer is returning error (#1111)
7ab6bb5 
* AP-4284 Save BPMN Model on Process Discoverer is returning error

* Remove unnecessary method
@Janite
Bugfix/AP-4292/select all select none labels switched (#1114)
c7e58ca 
- fix: remove duplicate cancelButton_label and merge conflict text
- fix: Move select all and select none text to the correct label key
Change properties
81b1cf2
Merge branch 'refactor3' of github.com:apromore/ApromoreCore into ref…
6ccf8a8 
…actor3
Added docker-compose
6f4d3f9
karthik-balasubramanian
karthik-balasubramanian approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@karthik-balasubramanian karthik-balasubramanian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raboczi
raboczi approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@raboczi raboczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been walked through the code and done some basic functional testing, enough to feel that this is better merged than delayed further. Approved!

@franklma franklma merged commit f7809f4 into development Jul 27, 2021
@raboczi raboczi deleted the refactor3 branch April 29, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboczi raboczi raboczi approved these changes

@karthik-balasubramanian karthik-balasubramanian karthik-balasubramanian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
8 participants
@nolantellis @raboczi @karthik-balasubramanian @franklma @Janite @mayankgituni @justinapromore @mayanktomar20