Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Academic release bugfixes #189

Merged
merged 5 commits into from
Apr 9, 2019
Merged

Academic release bugfixes #189

merged 5 commits into from
Apr 9, 2019

Conversation

raboczi
Copy link
Contributor

@raboczi raboczi commented Apr 9, 2019

This is the candidate for bugfix release 7.0.1. It contains the following changes:

  • Headless installations like Docker used to fail because of Slickerbox-related code in the UIContext of ProM utilities. Changes in Raffaele Conforti's consolidated research code bundle now avoid this.
  • Opening a model version from the lower-left Process Details panel in the portal now uses bpmn.io rather than Signavio (https://github.com/apromore/ApromoreCore/issues/188)
  • The BPMN canoniser is now more lenient about accepting incomplete models.

There was work on adding BIMP annotation to BPMN Miner which was manually reverted; this means that minor but non-functional changes occurred within BPMN Miner. The SiMo functionality is on a separate branch and will be incorporated in the next feature release (presumably 7.1).

brucenguyen1 and others added 5 commits March 29, 2019 13:39
The current version of the SiMo extensions are available on the feature-process-discoverer-BIMP-annotation branch.
We need to be much more lenient with what the canoniser is willing to accept as input now that students are throwing weird models at it.
This commit allows unnamed flow elements, orphaned events, and unconnected data output associations.
Unconnected CPF object references are allowed.
BPMN complex gateways are allowed, even though they don't have an unambiguous CPF representation and therefore probably won't round-trip.
Don't NPE for orphaned BPMNDI elements.
@raboczi raboczi merged commit 786fd5e into master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants