Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-1481 Reorganize about #314

Merged
merged 1 commit into from
May 22, 2020
Merged

AP-1481 Reorganize about #314

merged 1 commit into from
May 22, 2020

Conversation

dreamind
Copy link
Contributor

No description provided.

@dreamind dreamind requested a review from raboczi May 21, 2020 15:01
raboczi
raboczi approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@raboczi raboczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not so great that MenuController in the portal treats menus named "About" and "Account" specially, but I appreciate that we'd otherwise have to add some API for plugins to request their menu items to be on the right side of the menubar.

@dreamind
Copy link
Contributor Author

It's not so great that MenuController in the portal treats menus named "About" and "Account" specially, but I appreciate that we'd otherwise have to add some API for plugins to request their menu items to be on the right side of the menubar.

Yes, I agree. We need a better way to handle this. Probably defining more comprehensive structure in site.properties (or a YAML-version of it) would make a better choice (in the future). I will create a placeholder ticket for this.

@dreamind dreamind merged commit ce0333f into v7.15 May 22, 2020
@dreamind dreamind deleted the hotfix/AP-1481-about-v7.15 branch May 22, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboczi raboczi raboczi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dreamind @raboczi