Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ap 2419 Add preConditions in LiquidBase changeSet to cover all scenarios #517

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Ap 2419 Add preConditions in LiquidBase changeSet to cover all scenarios #517

merged 2 commits into from
Oct 16, 2020

Conversation

franklma
Copy link
Contributor

No description provided.

brucenguyen1
brucenguyen1 reviewed Oct 15, 2020
View reviewed changes
Apromore-Database/src/main/resources/db/migration/changeLog-Schema.yaml Outdated
Comment on lines 464 to 476
- changeSet:
id: 20201014123300
author: frankm
failOnError: false
preConditions:
- onFail: MARK_RAN
- not:
- or:
- foreignKeyConstraintExists:
foreignKeyName: fk_user_group
- indexExists:
indexName: idx_search_history
- indexExists:
indexName: group_row_guid_UNIQUE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As foreign key name and index name are unique within a table but not across tables, adding "tableName: " under foreignKeyConstraintExists and indexExists would be more accurate. But it might not really necessary if a consistent naming convention is used for foreign key names and index names. It would be a problem in case of lacking a consistent naming convention.

group_row_guid_UNIQUE: it should have "idx" prefix to be consistent index name, like "idx_search_history".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly, FK and indexExists conditions don't support table attribute, according to the official document.
https://docs.liquibase.com/concepts/advanced/preconditions.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can try it, Frank. There are examples in here: https://github.com/liquibase/liquibase/blob/master/liquibase-integration-tests/src/test/resources/changelogs/yaml/common.tests.changelog.yaml. For foreign key: no need because it must be unique in a database.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I tested and working fine. Looks like the preConditions part is poorly documented.

brucenguyen1
brucenguyen1 approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@brucenguyen1 brucenguyen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works in both conditions: when a table/index/constraint exist or not exist. A consistent naming convention is quite important to follow.

@franklma franklma merged commit e450496 into development Oct 16, 2020
@franklma franklma deleted the AP-2419 branch October 16, 2020 00:53
stdevi pushed a commit that referenced this pull request Oct 25, 2020
Squashed commit of the following:
7318c23 
commit 92c91f8
Merge: db95b00 a33eebb
Author: dreamind <dreamind@gmail.com>
Date:   Sat Oct 24 20:57:01 2020 +1100

    Merge pull request #529 from apromore/feature/AP-2120-2432

    AP-2120-2432 Merge and PD shortcuts fixes

commit a33eebb
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Sat Oct 24 20:55:30 2020 +1100

    AP-2120-2432 Merge and PD shortcuts fixes

commit db95b00
Merge: f39f5eb 6812f38
Author: frankma <49012776+frank-ma-leonardo@users.noreply.github.com>
Date:   Thu Oct 22 12:29:04 2020 +1100

    Merge pull request #525 from apromore/AP-2431

    APIs to get dependent artifact of user metadata

commit 6812f38
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Thu Oct 22 09:49:16 2020 +1100

    Add method to get the usermetadata AccessType

commit 1e4e08b
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 21 17:41:39 2020 +1100

    Remove unnecessary assertions

commit f39f5eb
Merge: 41e0d21 e02129f
Author: raboczi <raboczi@icloud.com>
Date:   Wed Oct 21 15:12:05 2020 +1000

    Merge branch 'feature/AP-2416-hadoop-on-windows' into development

commit 41e0d21
Merge: 915b7bf 50f7b6c
Author: dreamind <dreamind@gmail.com>
Date:   Wed Oct 21 11:22:48 2020 +1100

    Merge pull request #526 from apromore/feature/AP-2236

    AP-2236 Fix long graph search result in PD

commit 50f7b6c
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Wed Oct 21 11:21:22 2020 +1100

    AP-2236 Fix long graph search result in PD

commit a1ecf9f
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 21 09:06:13 2020 +1100

    APIs to get dependent artifact of user metadata

commit 915b7bf
Merge: ba4a3be edef126
Author: dreamind <dreamind@gmail.com>
Date:   Wed Oct 21 08:12:16 2020 +1100

    Merge pull request #524 from apromore/feature/AP-2120

    AP-2120 Refine merge model interface

commit edef126
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Tue Oct 20 23:43:40 2020 +1100

    AP-2120 Update package and classname in apromore-commons

commit 617c9a0
Author: Bruce Nguyen <hoangnguyen7x@yahoo.com>
Date:   Tue Oct 20 19:04:16 2020 +1000

    Fix mispelling: org.joda.time.DateTimeUtilss.

commit 4d6a08d
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Tue Oct 20 00:15:08 2020 +1100

    AP-2120 Refine merge model interface

commit ba4a3be
Merge: a725fe5 209c4dd
Author: Simon Raboczi <raboczi@users.noreply.github.com>
Date:   Tue Oct 20 16:41:05 2020 +1000

    Merge pull request #523 from apromore/bug/dbweaving-on-windows/AP-2437

    Bug/dbweaving on windows/ap 2437

commit 209c4dd
Author: Nolan Tellis <nolan.tellis@apromore.com>
Date:   Tue Oct 20 14:43:54 2020 +1100

    Fix static weaving on windows

commit a725fe5
Merge: 513f5b0 f3e3157
Author: dreamind <dreamind@gmail.com>
Date:   Tue Oct 20 12:08:35 2020 +1100

    Merge pull request #522 from apromore/AP-2446

    AP-2446 Fix regression in portal search

commit 513f5b0
Author: Chii Chang <chiichang@users.noreply.github.com>
Date:   Tue Oct 20 11:35:39 2020 +1100

    added unit tests for new filter logics

commit f3e3157
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Tue Oct 20 10:36:33 2020 +1100

    AP-2446 Fix regression in portal search

commit d127188
Author: Chii Chang <chiichang@users.noreply.github.com>
Date:   Mon Oct 19 17:16:37 2020 +1100

    Reduce the number of points in default chart series

commit 3ab3013
Merge: 2d4fdca fe8b936
Author: Chii Chang <chiichang@users.noreply.github.com>
Date:   Mon Oct 19 16:11:34 2020 +1100

    Merge pull request #521 from apromore/feature/AP-2432

    AP-2432 Update help and add single variant check for quick filter sho…

commit fe8b936
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Fri Oct 16 16:55:08 2020 +1100

    AP-2432 Update help and add single variant check for quick filter shortcut in PD

commit 2d4fdca
Merge: 52a1df6 44ee20f
Author: frankma <49012776+frank-ma-leonardo@users.noreply.github.com>
Date:   Mon Oct 19 15:17:26 2020 +1100

    Merge pull request #513 from apromore/AP-2304

    Ap 2304 Backend service for sharing artifact (Log, Process, Folder)

commit 52a1df6
Author: Chii Chang <chiichang@users.noreply.github.com>
Date:   Mon Oct 19 15:09:38 2020 +1100

    added new mthod for getting attribute arc duration

commit 44ee20f
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Mon Oct 19 14:29:08 2020 +1100

    Change method signature

commit ddba89c
Merge: 4906071 c8f7c5d
Author: Chii Chang <chiichang@users.noreply.github.com>
Date:   Mon Oct 19 14:28:51 2020 +1100

    Merge pull request #519 from apromore/feature/AP-2432

    AP-2432 Add additional quick filter shortcut in PD

commit c8f7c5d
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Fri Oct 16 16:55:08 2020 +1100

    AP-2432 Add additional quick filter shortcut in PD

commit e02129f
Author: raboczi <raboczi@icloud.com>
Date:   Mon Oct 19 10:19:54 2020 +1000

    Added a comment noting where to obtain the precompiled Hadoop support files for Windows.  (AP-2416)

commit 52e16e3
Merge: 296499e f883dea
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Sat Oct 17 11:53:08 2020 +1100

    Rebase

commit 296499e
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Sat Oct 17 11:34:20 2020 +1100

    Fix regressions

commit 83f702e
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Fri Oct 16 18:54:09 2020 +1100

    Reverse IN clause code due to possible incompatibility of spring JPA

commit 4513fde
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Fri Oct 16 15:22:04 2020 +1100

    Refactor access control APIs out of WorkspaceService to AuthorizationService

commit 8d5afe4
Author: Nolan Tellis <nolan.tellis@apromore.com>
Date:   Thu Oct 15 15:29:02 2020 +1100

    Minor refactoring and test correction

commit b85c981
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 14 23:46:46 2020 +1100

    comment

commit 9dc003c
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 14 09:36:03 2020 +1100

    Fix equal and hashcode methods in Usermetadata POJO

commit 3e37743
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Tue Oct 13 16:00:32 2020 +1100

    Add unit tests

commit 5779539
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Mon Oct 12 11:01:54 2020 +1100

    Feature: CRUD functions for ACL of Log/Process/Folder

commit 3470570
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Thu Oct 8 15:01:16 2020 +1100

    Remove unnecessary cascading in GroupUserMetadata

commit fdb0296
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 7 22:04:18 2020 +1100

    Fix metadata permission after deleting of Log

commit ab79340
Author: raboczi <raboczi@icloud.com>
Date:   Fri Oct 16 14:22:13 2020 +1000

    Created TestUtilities.resourceToString to centralize test document processing.

    This should allow documents to be normalized to unix-style line endings for byte-wise comparison in the tests.

commit 4906071
Merge: e450496 69e0dbe
Author: dreamind <dreamind@gmail.com>
Date:   Fri Oct 16 15:07:41 2020 +1100

    Merge pull request #518 from apromore/feature/AP-2311-2

    AP-2311 Increase notification hide delay

commit 3aaf13f
Merge: 638a694 e450496
Author: raboczi <raboczi@icloud.com>
Date:   Fri Oct 16 13:40:05 2020 +1000

    Merge branch 'development' into feature/AP-2416-hadoop-on-windows

commit 638a694
Author: Simon Raboczi <simon.raboczi@unimelb.edu.au>
Date:   Thu Oct 15 19:51:04 2020 -0700

    Added hadoop.home.dir system property to CSV Importer logic test environment.

commit 69e0dbe
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Fri Oct 16 13:00:16 2020 +1100

    AP-2311 Increase notification hide delay

commit e450496
Merge: 1960299 456ec72
Author: frankma <49012776+frank-ma-leonardo@users.noreply.github.com>
Date:   Fri Oct 16 11:53:24 2020 +1100

    Merge pull request #517 from apromore/AP-2419

    Ap 2419 Add preConditions in LiquidBase changeSet to cover all scenarios

commit 456ec72
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Fri Oct 16 10:52:54 2020 +1100

    Add tableName in indexExists preCondition and change indexName to follow naming conventions

commit cd728d1
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Thu Oct 15 19:42:44 2020 +1100

    Add preConditions in liquidbase changeSet to cover all scenarios

commit 1960299
Merge: 0ce6820 546e05b
Author: Simon Raboczi <raboczi@users.noreply.github.com>
Date:   Thu Oct 15 16:15:17 2020 +1000

    Merge pull request #507 from apromore/feature/AP-2409-enable-checkstyle

    Re-enabled pre-existing Checkstyle code. (AP-2409)

commit 546e05b
Author: raboczi <raboczi@icloud.com>
Date:   Thu Oct 15 16:04:37 2020 +1000

    Incorporated feedback to checkstyle.xml

    - trailing whitespace is permitted if the line is entirely whitespace; this allows Eclipse's auto-indentation
    - documentation links normalized to checkstyle.org

commit f883dea
Author: Nolan Tellis <nolan.tellis@apromore.com>
Date:   Thu Oct 15 15:29:02 2020 +1100

    Minor refactoring and test correction

commit 98ca972
Merge: cba9542 0ce6820
Author: Nolan Tellis <nolan.tellis@apromore.com>
Date:   Thu Oct 15 14:44:28 2020 +1100

    Merge remote-tracking branch 'origin/development' into AP-2304

commit 0ce6820
Merge: d5db52e 1c93e1f
Author: Simon Raboczi <raboczi@users.noreply.github.com>
Date:   Thu Oct 15 12:00:21 2020 +1000

    Merge pull request #516 from apromore/bugfix/apromore-commons

    Fixed build failure in Apromore-Portal

commit 1c93e1f
Author: raboczi <raboczi@icloud.com>
Date:   Thu Oct 15 11:53:42 2020 +1000

    Fixed build failure in Apromore-Portal pom.xml: commons dependency should be apromore-commons

commit d5db52e
Merge: d70f308 5715b70
Author: Simon Raboczi <raboczi@users.noreply.github.com>
Date:   Thu Oct 15 11:04:03 2020 +1000

    Merge pull request #515 from apromore/bugfix/create-h2

    Modified "ant create-h2" for Liquibase compatibility.

commit 38aa01e
Merge: a8be97c 5715b70
Author: raboczi <raboczi@icloud.com>
Date:   Thu Oct 15 11:03:03 2020 +1000

    Merge branch 'bugfix/create-h2' into feature/AP-2416-hadoop-on-windows

commit 5715b70
Author: raboczi <raboczi@icloud.com>
Date:   Thu Oct 15 10:38:42 2020 +1000

    Modified "ant create-h2" for Liquibase compatibility.

commit d70f308
Merge: 4f73c0a 3eb998e
Author: dreamind <dreamind@gmail.com>
Date:   Thu Oct 15 10:17:16 2020 +1100

    Merge pull request #514 from apromore/feature/AP-1160-2

    AP-1160 Commons source code formatting

commit 3eb998e
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Thu Oct 15 10:16:03 2020 +1100

    AP-1160 Commons source code formatting

commit 4f73c0a
Merge: 3c4afd1 ccb80c6
Author: dreamind <dreamind@gmail.com>
Date:   Thu Oct 15 09:13:35 2020 +1100

    Merge pull request #509 from apromore/feature/AP-1160

    AP-1160 Refactor date, time and duration handling

commit cba9542
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 14 23:46:46 2020 +1100

    comment

commit ec444c9
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 14 09:36:03 2020 +1100

    Fix equal and hashcode methods in Usermetadata POJO

commit eaa3f00
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Tue Oct 13 16:00:32 2020 +1100

    Add unit tests

commit be2cdb4
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Mon Oct 12 11:01:54 2020 +1100

    Feature: CRUD functions for ACL of Log/Process/Folder

commit 22e2d4a
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Thu Oct 8 15:01:16 2020 +1100

    Remove unnecessary cascading in GroupUserMetadata

commit edaddb6
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 7 22:04:18 2020 +1100

    Fix metadata permission after deleting of Log

commit a8be97c
Author: raboczi <raboczi@icloud.com>
Date:   Wed Oct 14 16:37:46 2020 +1000

    Fixed "ant create-h2" target, broken when Apromore-Database relocated the SQL scripts.

commit 3c4afd1
Merge: 0c5bbf4 644c7eb
Author: frankma <49012776+frank-ma-leonardo@users.noreply.github.com>
Date:   Wed Oct 14 16:11:51 2020 +1100

    Merge pull request #512 from apromore/AP-2419

    AP-2419 Fix regressions in user metadata features

commit ccb80c6
Author: Nolan Tellis <nolan.tellis@apromore.com>
Date:   Wed Oct 14 15:27:10 2020 +1100

    Minor refactoring to remove unwanted loops

commit c0478dc
Author: raboczi <raboczi@icloud.com>
Date:   Wed Oct 14 12:57:30 2020 +1000

    Added the latest precompiled native Windows libraries to support Hadoop (AP-2416)

    Beware that the latest precompiled native libraries are 3.2.1, whereas Apromore is using Hadoop 3.3.0.

commit 644c7eb
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 14 13:32:05 2020 +1100

    AP-2419 Fix regressions in user metadata features

commit 0c5bbf4
Merge: b6b80d5 06cac7f
Author: dreamind <dreamind@gmail.com>
Date:   Wed Oct 14 12:39:24 2020 +1100

    Merge pull request #511 from apromore/feature/AP-2244-2

    AP-2244 Check only one selection for rename

commit abfe339
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Mon Oct 12 14:54:31 2020 +1100

    AP-1160 Refactor date, time and duration handling

commit 06cac7f
Author: Nolan Tellis <nolan.tellis@apromore.com>
Date:   Wed Oct 14 11:18:47 2020 +1100

    Minor changes in code function

commit a526e56
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Tue Oct 13 17:23:12 2020 +1100

    AP-2244 Check only one selection for rename

commit f7a19e1
Author: raboczi <raboczi@icloud.com>
Date:   Mon Oct 12 16:34:22 2020 +1000

    Re-enabled pre-existing Checkstyle code. (AP-2409)

    Updated Checkstyle from v2 to v3; the old (partially incompatible checkstyle XML is retained as checkstyle-v2.xml).
    The v3 (checkstyle.xml) is mostly default; Javadoc, DesignForExtension, and OperatorWrap are notable changes.
stdevi pushed a commit that referenced this pull request Oct 27, 2020
Squashed commit of the following:
f3a4256 
commit 21bfd78
Merge: 4d313ee 90ab321
Author: dreamind <dreamind@gmail.com>
Date:   Wed Oct 28 00:16:04 2020 +1100

    Merge pull request #528 from apromore/feature/AP-2303

    AP-2303 Share Dialog

commit 90ab321
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Tue Oct 27 23:52:27 2020 +1100

    AP-2303 Disable folder sharing and check remaining/duplicates

commit 125245e
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Mon Oct 26 18:47:20 2020 +1100

    Fix copyright headers

commit 1cc8057
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Wed Sep 23 17:45:02 2020 +1000

    AP-2303 Share Dialog

commit 4d313ee
Merge: ca1747d caeda21
Author: Simon Raboczi <raboczi@users.noreply.github.com>
Date:   Tue Oct 27 13:35:29 2020 +1000

    Merge pull request #530 from apromore/feature/AP-2300

    fixed encoding

commit ca1747d
Merge: 92c91f8 688f702
Author: Simon Raboczi <raboczi@users.noreply.github.com>
Date:   Tue Oct 27 12:57:06 2020 +1000

    Merge pull request #531 from apromore/feature/AP-2384-refactor-OSGi-manifest

    Feature/AP-2384 Refactor OSGi manifest

commit 688f702
Author: raboczi <raboczi@icloud.com>
Date:   Mon Oct 26 22:23:46 2020 +1000

    Removed remaining OSGi Import-Bundle manifest headers. (AP-2384)

commit fad0cfa
Author: raboczi <raboczi@icloud.com>
Date:   Mon Oct 26 16:53:20 2020 +1000

    Removed use of OSGi Import-Bundle from Apromore-Manager (AP-2384)

commit 92c91f8
Merge: db95b00 a33eebb
Author: dreamind <dreamind@gmail.com>
Date:   Sat Oct 24 20:57:01 2020 +1100

    Merge pull request #529 from apromore/feature/AP-2120-2432

    AP-2120-2432 Merge and PD shortcuts fixes

commit a33eebb
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Sat Oct 24 20:55:30 2020 +1100

    AP-2120-2432 Merge and PD shortcuts fixes

commit db95b00
Merge: f39f5eb 6812f38
Author: frankma <49012776+frank-ma-leonardo@users.noreply.github.com>
Date:   Thu Oct 22 12:29:04 2020 +1100

    Merge pull request #525 from apromore/AP-2431

    APIs to get dependent artifact of user metadata

commit 6812f38
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Thu Oct 22 09:49:16 2020 +1100

    Add method to get the usermetadata AccessType

commit 1e4e08b
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 21 17:41:39 2020 +1100

    Remove unnecessary assertions

commit f39f5eb
Merge: 41e0d21 e02129f
Author: raboczi <raboczi@icloud.com>
Date:   Wed Oct 21 15:12:05 2020 +1000

    Merge branch 'feature/AP-2416-hadoop-on-windows' into development

commit 41e0d21
Merge: 915b7bf 50f7b6c
Author: dreamind <dreamind@gmail.com>
Date:   Wed Oct 21 11:22:48 2020 +1100

    Merge pull request #526 from apromore/feature/AP-2236

    AP-2236 Fix long graph search result in PD

commit 50f7b6c
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Wed Oct 21 11:21:22 2020 +1100

    AP-2236 Fix long graph search result in PD

commit a1ecf9f
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 21 09:06:13 2020 +1100

    APIs to get dependent artifact of user metadata

commit 915b7bf
Merge: ba4a3be edef126
Author: dreamind <dreamind@gmail.com>
Date:   Wed Oct 21 08:12:16 2020 +1100

    Merge pull request #524 from apromore/feature/AP-2120

    AP-2120 Refine merge model interface

commit edef126
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Tue Oct 20 23:43:40 2020 +1100

    AP-2120 Update package and classname in apromore-commons

commit 617c9a0
Author: Bruce Nguyen <hoangnguyen7x@yahoo.com>
Date:   Tue Oct 20 19:04:16 2020 +1000

    Fix mispelling: org.joda.time.DateTimeUtilss.

commit 4d6a08d
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Tue Oct 20 00:15:08 2020 +1100

    AP-2120 Refine merge model interface

commit ba4a3be
Merge: a725fe5 209c4dd
Author: Simon Raboczi <raboczi@users.noreply.github.com>
Date:   Tue Oct 20 16:41:05 2020 +1000

    Merge pull request #523 from apromore/bug/dbweaving-on-windows/AP-2437

    Bug/dbweaving on windows/ap 2437

commit 209c4dd
Author: Nolan Tellis <nolan.tellis@apromore.com>
Date:   Tue Oct 20 14:43:54 2020 +1100

    Fix static weaving on windows

commit a725fe5
Merge: 513f5b0 f3e3157
Author: dreamind <dreamind@gmail.com>
Date:   Tue Oct 20 12:08:35 2020 +1100

    Merge pull request #522 from apromore/AP-2446

    AP-2446 Fix regression in portal search

commit 513f5b0
Author: Chii Chang <chiichang@users.noreply.github.com>
Date:   Tue Oct 20 11:35:39 2020 +1100

    added unit tests for new filter logics

commit f3e3157
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Tue Oct 20 10:36:33 2020 +1100

    AP-2446 Fix regression in portal search

commit d127188
Author: Chii Chang <chiichang@users.noreply.github.com>
Date:   Mon Oct 19 17:16:37 2020 +1100

    Reduce the number of points in default chart series

commit 3ab3013
Merge: 2d4fdca fe8b936
Author: Chii Chang <chiichang@users.noreply.github.com>
Date:   Mon Oct 19 16:11:34 2020 +1100

    Merge pull request #521 from apromore/feature/AP-2432

    AP-2432 Update help and add single variant check for quick filter sho…

commit fe8b936
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Fri Oct 16 16:55:08 2020 +1100

    AP-2432 Update help and add single variant check for quick filter shortcut in PD

commit 2d4fdca
Merge: 52a1df6 44ee20f
Author: frankma <49012776+frank-ma-leonardo@users.noreply.github.com>
Date:   Mon Oct 19 15:17:26 2020 +1100

    Merge pull request #513 from apromore/AP-2304

    Ap 2304 Backend service for sharing artifact (Log, Process, Folder)

commit 52a1df6
Author: Chii Chang <chiichang@users.noreply.github.com>
Date:   Mon Oct 19 15:09:38 2020 +1100

    added new mthod for getting attribute arc duration

commit 44ee20f
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Mon Oct 19 14:29:08 2020 +1100

    Change method signature

commit ddba89c
Merge: 4906071 c8f7c5d
Author: Chii Chang <chiichang@users.noreply.github.com>
Date:   Mon Oct 19 14:28:51 2020 +1100

    Merge pull request #519 from apromore/feature/AP-2432

    AP-2432 Add additional quick filter shortcut in PD

commit c8f7c5d
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Fri Oct 16 16:55:08 2020 +1100

    AP-2432 Add additional quick filter shortcut in PD

commit e02129f
Author: raboczi <raboczi@icloud.com>
Date:   Mon Oct 19 10:19:54 2020 +1000

    Added a comment noting where to obtain the precompiled Hadoop support files for Windows.  (AP-2416)

commit 52e16e3
Merge: 296499e f883dea
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Sat Oct 17 11:53:08 2020 +1100

    Rebase

commit 296499e
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Sat Oct 17 11:34:20 2020 +1100

    Fix regressions

commit 83f702e
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Fri Oct 16 18:54:09 2020 +1100

    Reverse IN clause code due to possible incompatibility of spring JPA

commit 4513fde
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Fri Oct 16 15:22:04 2020 +1100

    Refactor access control APIs out of WorkspaceService to AuthorizationService

commit 8d5afe4
Author: Nolan Tellis <nolan.tellis@apromore.com>
Date:   Thu Oct 15 15:29:02 2020 +1100

    Minor refactoring and test correction

commit b85c981
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 14 23:46:46 2020 +1100

    comment

commit 9dc003c
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 14 09:36:03 2020 +1100

    Fix equal and hashcode methods in Usermetadata POJO

commit 3e37743
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Tue Oct 13 16:00:32 2020 +1100

    Add unit tests

commit 5779539
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Mon Oct 12 11:01:54 2020 +1100

    Feature: CRUD functions for ACL of Log/Process/Folder

commit 3470570
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Thu Oct 8 15:01:16 2020 +1100

    Remove unnecessary cascading in GroupUserMetadata

commit fdb0296
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 7 22:04:18 2020 +1100

    Fix metadata permission after deleting of Log

commit ab79340
Author: raboczi <raboczi@icloud.com>
Date:   Fri Oct 16 14:22:13 2020 +1000

    Created TestUtilities.resourceToString to centralize test document processing.

    This should allow documents to be normalized to unix-style line endings for byte-wise comparison in the tests.

commit 4906071
Merge: e450496 69e0dbe
Author: dreamind <dreamind@gmail.com>
Date:   Fri Oct 16 15:07:41 2020 +1100

    Merge pull request #518 from apromore/feature/AP-2311-2

    AP-2311 Increase notification hide delay

commit 3aaf13f
Merge: 638a694 e450496
Author: raboczi <raboczi@icloud.com>
Date:   Fri Oct 16 13:40:05 2020 +1000

    Merge branch 'development' into feature/AP-2416-hadoop-on-windows

commit 638a694
Author: Simon Raboczi <simon.raboczi@unimelb.edu.au>
Date:   Thu Oct 15 19:51:04 2020 -0700

    Added hadoop.home.dir system property to CSV Importer logic test environment.

commit 69e0dbe
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Fri Oct 16 13:00:16 2020 +1100

    AP-2311 Increase notification hide delay

commit e450496
Merge: 1960299 456ec72
Author: frankma <49012776+frank-ma-leonardo@users.noreply.github.com>
Date:   Fri Oct 16 11:53:24 2020 +1100

    Merge pull request #517 from apromore/AP-2419

    Ap 2419 Add preConditions in LiquidBase changeSet to cover all scenarios

commit 456ec72
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Fri Oct 16 10:52:54 2020 +1100

    Add tableName in indexExists preCondition and change indexName to follow naming conventions

commit cd728d1
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Thu Oct 15 19:42:44 2020 +1100

    Add preConditions in liquidbase changeSet to cover all scenarios

commit 1960299
Merge: 0ce6820 546e05b
Author: Simon Raboczi <raboczi@users.noreply.github.com>
Date:   Thu Oct 15 16:15:17 2020 +1000

    Merge pull request #507 from apromore/feature/AP-2409-enable-checkstyle

    Re-enabled pre-existing Checkstyle code. (AP-2409)

commit 546e05b
Author: raboczi <raboczi@icloud.com>
Date:   Thu Oct 15 16:04:37 2020 +1000

    Incorporated feedback to checkstyle.xml

    - trailing whitespace is permitted if the line is entirely whitespace; this allows Eclipse's auto-indentation
    - documentation links normalized to checkstyle.org

commit f883dea
Author: Nolan Tellis <nolan.tellis@apromore.com>
Date:   Thu Oct 15 15:29:02 2020 +1100

    Minor refactoring and test correction

commit 98ca972
Merge: cba9542 0ce6820
Author: Nolan Tellis <nolan.tellis@apromore.com>
Date:   Thu Oct 15 14:44:28 2020 +1100

    Merge remote-tracking branch 'origin/development' into AP-2304

commit 0ce6820
Merge: d5db52e 1c93e1f
Author: Simon Raboczi <raboczi@users.noreply.github.com>
Date:   Thu Oct 15 12:00:21 2020 +1000

    Merge pull request #516 from apromore/bugfix/apromore-commons

    Fixed build failure in Apromore-Portal

commit 1c93e1f
Author: raboczi <raboczi@icloud.com>
Date:   Thu Oct 15 11:53:42 2020 +1000

    Fixed build failure in Apromore-Portal pom.xml: commons dependency should be apromore-commons

commit d5db52e
Merge: d70f308 5715b70
Author: Simon Raboczi <raboczi@users.noreply.github.com>
Date:   Thu Oct 15 11:04:03 2020 +1000

    Merge pull request #515 from apromore/bugfix/create-h2

    Modified "ant create-h2" for Liquibase compatibility.

commit 38aa01e
Merge: a8be97c 5715b70
Author: raboczi <raboczi@icloud.com>
Date:   Thu Oct 15 11:03:03 2020 +1000

    Merge branch 'bugfix/create-h2' into feature/AP-2416-hadoop-on-windows

commit 5715b70
Author: raboczi <raboczi@icloud.com>
Date:   Thu Oct 15 10:38:42 2020 +1000

    Modified "ant create-h2" for Liquibase compatibility.

commit d70f308
Merge: 4f73c0a 3eb998e
Author: dreamind <dreamind@gmail.com>
Date:   Thu Oct 15 10:17:16 2020 +1100

    Merge pull request #514 from apromore/feature/AP-1160-2

    AP-1160 Commons source code formatting

commit 3eb998e
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Thu Oct 15 10:16:03 2020 +1100

    AP-1160 Commons source code formatting

commit 4f73c0a
Merge: 3c4afd1 ccb80c6
Author: dreamind <dreamind@gmail.com>
Date:   Thu Oct 15 09:13:35 2020 +1100

    Merge pull request #509 from apromore/feature/AP-1160

    AP-1160 Refactor date, time and duration handling

commit cba9542
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 14 23:46:46 2020 +1100

    comment

commit ec444c9
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 14 09:36:03 2020 +1100

    Fix equal and hashcode methods in Usermetadata POJO

commit eaa3f00
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Tue Oct 13 16:00:32 2020 +1100

    Add unit tests

commit be2cdb4
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Mon Oct 12 11:01:54 2020 +1100

    Feature: CRUD functions for ACL of Log/Process/Folder

commit 22e2d4a
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Thu Oct 8 15:01:16 2020 +1100

    Remove unnecessary cascading in GroupUserMetadata

commit edaddb6
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 7 22:04:18 2020 +1100

    Fix metadata permission after deleting of Log

commit a8be97c
Author: raboczi <raboczi@icloud.com>
Date:   Wed Oct 14 16:37:46 2020 +1000

    Fixed "ant create-h2" target, broken when Apromore-Database relocated the SQL scripts.

commit 3c4afd1
Merge: 0c5bbf4 644c7eb
Author: frankma <49012776+frank-ma-leonardo@users.noreply.github.com>
Date:   Wed Oct 14 16:11:51 2020 +1100

    Merge pull request #512 from apromore/AP-2419

    AP-2419 Fix regressions in user metadata features

commit ccb80c6
Author: Nolan Tellis <nolan.tellis@apromore.com>
Date:   Wed Oct 14 15:27:10 2020 +1100

    Minor refactoring to remove unwanted loops

commit c0478dc
Author: raboczi <raboczi@icloud.com>
Date:   Wed Oct 14 12:57:30 2020 +1000

    Added the latest precompiled native Windows libraries to support Hadoop (AP-2416)

    Beware that the latest precompiled native libraries are 3.2.1, whereas Apromore is using Hadoop 3.3.0.

commit 644c7eb
Author: frank-ma-leonardo <f.ma@leonardo.com.au>
Date:   Wed Oct 14 13:32:05 2020 +1100

    AP-2419 Fix regressions in user metadata features

commit 0c5bbf4
Merge: b6b80d5 06cac7f
Author: dreamind <dreamind@gmail.com>
Date:   Wed Oct 14 12:39:24 2020 +1100

    Merge pull request #511 from apromore/feature/AP-2244-2

    AP-2244 Check only one selection for rename

commit abfe339
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Mon Oct 12 14:54:31 2020 +1100

    AP-1160 Refactor date, time and duration handling

commit 06cac7f
Author: Nolan Tellis <nolan.tellis@apromore.com>
Date:   Wed Oct 14 11:18:47 2020 +1100

    Minor changes in code function

commit a526e56
Author: Ivo Widjaja <dreamind@gmail.com>
Date:   Tue Oct 13 17:23:12 2020 +1100

    AP-2244 Check only one selection for rename

commit caeda21
Author: Own Daghagheleh <>
Date:   Tue Oct 13 14:05:30 2020 +1100

    fixed encoding

commit f7a19e1
Author: raboczi <raboczi@icloud.com>
Date:   Mon Oct 12 16:34:22 2020 +1000

    Re-enabled pre-existing Checkstyle code. (AP-2409)

    Updated Checkstyle from v2 to v3; the old (partially incompatible checkstyle XML is retained as checkstyle-v2.xml).
    The v3 (checkstyle.xml) is mostly default; Javadoc, DesignForExtension, and OperatorWrap are notable changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolantellis nolantellis Awaiting requested review from nolantellis

@brucenguyen1 brucenguyen1 Awaiting requested review from brucenguyen1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@franklma @brucenguyen1