Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to rename only if authorized #601

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Add support to rename only if authorized #601

merged 2 commits into from
Dec 8, 2020

Conversation

nolantellis
Copy link
Contributor

No description provided.

raboczi
raboczi approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@raboczi raboczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. One quibble: did you intentionally reindent BaseListboxController? Eventually I'd like to enable checkstyle and ban tab characters.

franklma
franklma requested changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@franklma franklma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A user with VIEWER access type can't rename log, process and folder as expected. However, there is casualty that user with proper access type can not rename a folder.

@nolantellis nolantellis self-assigned this Dec 8, 2020
@nolantellis
Copy link
Contributor Author

A user with VIEWER access type can't rename log, process and folder as expected. However, there is casualty that user with proper access type can not rename a folder.

This is in dev too, Have fixed it

@nolantellis nolantellis merged commit ca87bf8 into development Dec 8, 2020
@raboczi raboczi deleted the bug/rename-folder-file/AP-1228 branch December 18, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklma franklma franklma approved these changes

@raboczi raboczi Awaiting requested review from raboczi

Assignees

@nolantellis nolantellis

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nolantellis @raboczi @franklma