Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Hikari pooling and removed BonCp #745

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Added Hikari pooling and removed BonCp #745

merged 2 commits into from
Feb 5, 2021

Conversation

nolantellis
Copy link
Contributor

Removed BonCp and added hikari

  • Removed not required modules of plugin-database

@raboczi
Copy link
Contributor

raboczi commented Feb 5, 2021

I found some additional dependencies on the now-removed database driver fragments and removed them.

raboczi
raboczi approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@raboczi raboczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with MySQL 8 as well successfully. Less code is best code!

@raboczi raboczi merged commit f19a330 into development Feb 5, 2021
@raboczi raboczi deleted the task/Hikari/AP-3200 branch February 5, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboczi raboczi raboczi approved these changes

@franklma franklma Awaiting requested review from franklma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nolantellis @raboczi