Surf model #300
Merged
Surf model #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
agheata
force-pushed
the
surf_model
branch
2 times, most recently
from
ac0ecd8
to
a3d7dab
Compare
When VECGEOM_USE_SURF is detected and ADEPT_USE_SURF is set, the default navigator becomes SurfNavigator, which dispatches to BVHSurfNavigator. Additionally, setting ADEPT_USE_SURF_SINGLE uses the surface model in single precision (when this feature will be available)
* AdePT must be configured in Debug mode and DEBUG_SINGLE_THREAD=ON * Added colors to cmake messages.
JuanGonzalezCaminero
approved these changes
Aug 14, 2024
|
We merge this because it can process all geometries without overlaps, but we know that there are still fixes to be done to be able to validate the model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables the surface model if
VECGEOM_USE_SURFis detected in VecGeom, andADEPT_USE_SURFis ON (default OFF)This triggers
using AdePTNavigator = SurfNavigatorwhich gets used for the geometry calls.Behind
SurfNavigatorwe use for nowvgbrep::Navigatorloop navigator for theLocateandSafetycalls, andvgbrep::BVHSurfNavigatorforComputeStep.Using
ADEPT_USE_SURF_SINGLEadditionally triggers the surface model with a single precision. When available, this flag will be cross-checked against a corresponding flag in VecGeom.