Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve documentation for ClusterVulnerabilityReports #1910

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

sudoleg
Copy link
Contributor

@sudoleg sudoleg commented Mar 12, 2024

Description

From the documentation and the description of helm values it's not obvious that SBOM generation is required to enable ClusterVulnerabilityReports. @chen-keinan told me about that in discussion #1898. I proposed an adjustment of the documentation for this part.

Related issues/discussions

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2024

CLA assistant check
All committers have signed the CLA.

@sudoleg sudoleg closed this Mar 12, 2024
@sudoleg sudoleg reopened this Mar 12, 2024
Signed-off-by: Korznikov, Oleg <oleg.korznikov@hansemerkur.de>
Signed-off-by: Korznikov, Oleg <oleg.korznikov@hansemerkur.de>
@sudoleg sudoleg changed the title Improve documentation for ClusterVulnerabilityReports docs: Improve documentation for ClusterVulnerabilityReports Mar 12, 2024
Copy link
Collaborator

@chen-keinan chen-keinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudoleg lgtm 🚀 thanks for the contributions

@chen-keinan chen-keinan merged commit 5134307 into aquasecurity:main Mar 17, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants