Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style forms using django-bootstrap-form 3.4 #614

Merged

Conversation

hartwork
Copy link
Contributor

Candidate for #608.

Potentially one of the least invasive approaches to apply Bootstrap3 styling.
field.help_text was removed so that it's not shown twice.

Project home:

@codecov
Copy link

codecov bot commented Apr 19, 2018

Codecov Report

Merging #614 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
- Coverage   80.99%   80.97%   -0.02%     
==========================================
  Files          45       45              
  Lines        2920     2917       -3     
  Branches      177      177              
==========================================
- Hits         2365     2362       -3     
  Misses        497      497              
  Partials       58       58
Impacted Files Coverage Δ
cabot/settings.py 68.42% <ø> (ø) ⬆️
...t/templates/cabotapp/alertpluginuserdata_form.html 97.36% <100%> (ø) ⬆️
cabot/templates/cabotapp/plugin_settings_form.html 98.63% <100%> (ø) ⬆️
cabot/templates/cabotapp/_base_form.html 75.86% <100%> (-2.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b32a2...21454d0. Read the comment docs.

@@ -24,10 +26,5 @@
</div>
{% else %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still necessary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like that was an existing issue not created by this PR, so i think i'm just going to merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@frankh frankh merged commit 2410964 into arachnys:master Apr 20, 2018
@hartwork hartwork deleted the issue-608-approach-django-bootstrap-form branch April 21, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants