Reduce branding a bit? #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
=======================================
Coverage 80.98% 80.98%
=======================================
Files 45 45
Lines 2918 2918
Branches 177 177
=======================================
Hits 2363 2363
Misses 497 497
Partials 58 58
Continue to review full report at Codecov.
|
frankh
approved these changes
May 10, 2018
|
I'm ok with this, I agree the branding's unnecessary. @dbuxton what do you think? |
|
Fine by me |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This pull request is probably controversial. It is meant to start a discussion.
It may be a personal thing, a European thing, a cultural thing, you tell me. When I use software I don't like to look at company names all the time, the same way I try to keep my life as free from advertisements as possible. There are places where branding feels organic and fits in but there are two places in Cabot where I personally find the branding to invasive: they get too much attention in a way that is hard to look by. For daily operation, that matters. So this pull request reduces use of the Arachnys brand a bit.
Branding that is kept untouched includes:
README.md[Aa]rachnys\s+[Rr]ulesBranding that is removed:
by Arachnysin the top navigation bar and page titlehttps://www.arachnys.comfor an HTTP check endpoint example URLI'm happy to introduce a switch
DEBRAND=Falseor so todevelopment.envand friends to make this change conditional if it's more of the right direction.What do you think?