Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 page for anonymous user #625

Merged

Conversation

hartwork
Copy link
Contributor

@hartwork hartwork commented May 9, 2018

Meant to fix #624.

The anonymous user has ID None. Previously, this exception was raised:

NoReverseMatch: Reverse for 'user-profile' with arguments '(None,)' not found. 1 pattern(s) tried: ['user/(?P<pk>\\d+)/profile/$']

The anonymous user has ID `None`.  Previously, this exception was raised:
NoReverseMatch: Reverse for 'user-profile' with arguments '(None,)' not found. 1 pattern(s) tried: ['user/(?P<pk>\\d+)/profile/$']
@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #625 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   80.98%   81.03%   +0.05%     
==========================================
  Files          45       46       +1     
  Lines        2918     2927       +9     
  Branches      177      177              
==========================================
+ Hits         2363     2372       +9     
  Misses        497      497              
  Partials       58       58
Impacted Files Coverage Δ
cabot/templates/base.html 94.87% <100%> (+0.27%) ⬆️
cabot/templates/404.html 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8bb9d...fd66a86. Read the comment docs.

@frankh frankh merged commit 58b69f0 into arachnys:master May 10, 2018
@frankh
Copy link
Contributor

frankh commented May 10, 2018

Thanks 👍

@hartwork hartwork deleted the issue-624-fix-404-page-for-anonymous-user branch May 10, 2018 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 page raises exception unless logged in
2 participants