adding jenkins "discard old builds" feature #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sab3d - if you're still interested in adding this functionality, please add documentation to the feature you're adding in the doc block above the method. Otherwise, please close this issue. |
katelovescode
suggested changes
Nov 27, 2017
| @@ -299,6 +299,16 @@ def build_freestyle_config(params) | |||
| xml.description | |||
| xml.keepDependencies "#{params[:keep_dependencies]}" | |||
| xml.properties | |||
| #buildlogs related stuff | |||
| if params[:discard_old_builds] | |||
There was a problem hiding this comment.
If I understand correctly, this method build_freestyle_config only outputs the XML for a job config, rather than actually creating that job on the server. If so, this is 👍 to merge, I got response XML like this while using login_with_irb:
2.2.7 :001 > @client.job.build_freestyle_config({name: 'testjob', discard_old_builds: {daysToKeep: 3, numToKeep: 1, artifactDaysToKeep: 1, artifactNumToKeep: 1}})
=> "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<project>\n <actions/>\n <description/>\n <keepDependencies>false</keepDependencies>\n <properties/>\n <logRotator class=\"hudson.tasks.LogRotator\">\n <daysToKeep>3</daysToKeep>\n <numToKeep>1</numToKeep>\n <artifactDaysToKeep>1</artifactDaysToKeep>\n <artifactNumToKeep>1</artifactNumToKeep>\n </logRotator>\n <scm class=\"hudson.scm.NullSCM\"/>\n <canRoam>true</canRoam>\n <disabled>false</disabled>\n <blockBuildWhenDownstreamBuilding>false</blockBuildWhenDownstreamBuilding>\n <blockBuildWhenUpstreamBuilding>false</blockBuildWhenUpstreamBuilding>\n <triggers class=\"vector\"/>\n<concurrentBuild>false</concurrentBuild>\n <builders/>\n <publishers/>\n <buildWrappers/>\n</project>\n"
@arangamani as long as I understand this correctly, can you 👍 and merge?
katelovescode
approved these changes
Feb 13, 2018
arangamani
approved these changes
Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding jenkins "discard old builds" feature