Fixed issues in the README.md file for multiple projects.

Fixed the minimum chrome version in the manifest.json file.
archanaoswal · Aug 20, 2015 · 2c49af9 · 2c49af9
1 parent ba7762e
commit 2c49af9
Show file tree

Hide file tree

Showing 17 changed files with 45 additions and 50 deletions.
diff --git a/samples/webview-samples/declarative-web-request/README.md b/samples/webview-samples/declarative-web-request/README.md
@@ -31,5 +31,4 @@ top-right.
 
 
 ## Screenshot
-
-![screenshot](https://raw.github.com/GoogleChrome/chrome-app-samples/webview-samples/declarative-web-request/assets/screenshot_1280_800.png)
+![screenshot](/samples/webview-samples/declarative-web-request/assets/screenshot_1280_800.png)
diff --git a/samples/webview-samples/declarative-web-request/main.js b/samples/webview-samples/declarative-web-request/main.js
@@ -4,7 +4,7 @@
  * @see http://developer.chrome.com/apps/app.runtime.html
  * @see http://developer.chrome.com/apps/app.window.html
  */
-window.chrome.app.runtime.onLaunched.addListener(function() {
+chrome.app.runtime.onLaunched.addListener(function() {
   runApp();
 });
 
@@ -13,7 +13,7 @@ window.chrome.app.runtime.onLaunched.addListener(function() {
  *
  * @see http://developer.chrome.com/apps/app.runtime.html
  */
-window.chrome.app.runtime.onRestarted.addListener(function() {
+chrome.app.runtime.onRestarted.addListener(function() {
   runApp();
 });
 
@@ -23,7 +23,7 @@ window.chrome.app.runtime.onRestarted.addListener(function() {
  * @see http://developer.chrome.com/apps/app.window.html
  */
 function runApp() {
-  window.chrome.app.window.create(
+  chrome.app.window.create(
     'browser.html',
     {'id': 'initialBrowserWindowID', 'state': 'maximized'});
 }
diff --git a/samples/webview-samples/insert-css/README.md b/samples/webview-samples/insert-css/README.md
@@ -17,4 +17,4 @@ following links within the webview.
 
 ## Screenshot
 
-![screenshot](https://raw.github.com/mdittmer/chrome-app-samples/insert-css/webview-samples/insert-css/assets/screenshot_1280_800.png)
+![screenshot](/samples/webview-samples/insert-css/assets/screenshot_1280_800.png)
diff --git a/samples/webview-samples/insert-css/main.js b/samples/webview-samples/insert-css/main.js
@@ -4,7 +4,7 @@
  * @see http://developer.chrome.com/apps/app.runtime.html
  * @see http://developer.chrome.com/apps/app.window.html
  */
-window.chrome.app.runtime.onLaunched.addListener(function() {
+chrome.app.runtime.onLaunched.addListener(function() {
   runApp();
 });
 
@@ -13,7 +13,7 @@ window.chrome.app.runtime.onLaunched.addListener(function() {
  *
  * @see http://developer.chrome.com/apps/app.runtime.html
  */
-window.chrome.app.runtime.onRestarted.addListener(function() {
+chrome.app.runtime.onRestarted.addListener(function() {
   runApp();
 });
 
@@ -23,7 +23,7 @@ window.chrome.app.runtime.onRestarted.addListener(function() {
  * @see http://developer.chrome.com/apps/app.window.html
  */
 function runApp() {
-  window.chrome.app.window.create(
+  chrome.app.window.create(
     'browser.html',
     {'id': 'initialBrowserWindowID', 'state': 'maximized'});
 }
diff --git a/samples/webview-samples/local-resources/README.md b/samples/webview-samples/local-resources/README.md
@@ -24,4 +24,4 @@ to particular `webview` partitions to access trusted package-local content.
 
 
 ## Screenshot
-![screenshot](https://raw.github.com/mdittmer/chrome-app-samples/local-resources/webview-samples/local-resources/assets/screenshot_1280_800.png)
+![screenshot](/samples/webview-samples/local-resources/assets/screenshot_1280_800.png)
diff --git a/samples/webview-samples/local-resources/main.js b/samples/webview-samples/local-resources/main.js
@@ -4,7 +4,7 @@
  * @see http://developer.chrome.com/apps/app.runtime.html
  * @see http://developer.chrome.com/apps/app.window.html
  */
-window.chrome.app.runtime.onLaunched.addListener(function() {
+chrome.app.runtime.onLaunched.addListener(function() {
   runApp();
 });
 
@@ -13,7 +13,7 @@ window.chrome.app.runtime.onLaunched.addListener(function() {
  *
  * @see http://developer.chrome.com/apps/app.runtime.html
  */
-window.chrome.app.runtime.onRestarted.addListener(function() {
+chrome.app.runtime.onRestarted.addListener(function() {
   runApp();
 });
 
@@ -23,10 +23,10 @@ window.chrome.app.runtime.onRestarted.addListener(function() {
  * @see http://developer.chrome.com/apps/app.window.html
  */
 function runApp() {
-  window.chrome.app.window.create(
+  chrome.app.window.create(
     'good_app.html',
     {'id': 'GoodWindowID'});
-  window.chrome.app.window.create(
+  chrome.app.window.create(
     'bad_app.html',
     {'id': 'BadWindowID'});
 }
diff --git a/samples/webview-samples/multi-tab-browser/README.md b/samples/webview-samples/multi-tab-browser/README.md
@@ -1,27 +1,24 @@
 <a target="_blank" href="https://chrome.google.com/webstore/detail/jhgiafbilglmngpgkhcmnicfkpfihggo">![Try it now in CWS](https://raw.github.com/GoogleChrome/chrome-app-samples/master/tryitnowbutton.png "Click here to install this sample from the Chrome Web Store")</a>
 
 
-# New Window API
+# Multi-Tab Browser 
 
 Sample that shows one way to combine the [New Window
 API](https://developer.chrome.com/apps/tags/webview#event-newwindow) with the
 [User Agent
 API](https://developer.chrome.com/apps/tags/webview#method-setUserAgentOverride)
 for
 [webviews](http://developer.chrome.com/apps/app_external.html#webview). The
-app combines the [New Window
-Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/webview-samples/new-window)
-and the [User Agent
-Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/webview-samples/user-agent)
-by supporting `Open link in new tab/window as...` via the [Context Menu
-API](https://developer.chrome.com/extensions/contextMenus) (see screenshot).
+app combines the
+[New Window User Agent Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/new-window-user-agent)
+and the [Browser Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/browser).
 
 ## Features
 
-* All features from the [New Window
-Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/webview-samples/new-window)
-* Context menu entries for `Open link in new tab/window
-  as Android/iPhone/Nokia Mobile/BlackBerry Playbook`
+* All features from the [New Window User Agent Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/new-window-user-agent)
+* All features from the
+  [Browser Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/browser) except for [clearData API](https://developer.chrome.com/apps/tags/webview#method-clearData) and simulate crash.
+* Added a new permissions feature based on [webview permissinorequest event](https://developer.chrome.com/apps/tags/webview#event-permissionrequest)
 
 ## Limitations
 
@@ -35,6 +32,5 @@ Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/webview-s
 * [Webview](http://developer.chrome.com/apps/app_external.html#webview)
 * [Permissions](http://developer.chrome.com/apps/manifest.html#permissions)
 
-
 ## Screenshot
-![screenshot](/samples/webview-samples/new-window-user-agent/assets/screenshot_1280_800.png)
+![screenshot](/samples/webview-samples/multi-tab-browser/assets/screenshot_1280_800.png)
diff --git a/samples/webview-samples/multi-tab-browser/assets/screenshot_1280_800.png b/samples/webview-samples/multi-tab-browser/assets/screenshot_1280_800.png
diff --git a/samples/webview-samples/multi-tab-browser/main.js b/samples/webview-samples/multi-tab-browser/main.js
@@ -4,7 +4,7 @@
  * @see http://developer.chrome.com/apps/app.runtime.html
  * @see http://developer.chrome.com/apps/app.window.html
  */
-window.chrome.app.runtime.onLaunched.addListener(function() {
+chrome.app.runtime.onLaunched.addListener(function() {
   runApp();
 });
 
@@ -13,7 +13,7 @@ window.chrome.app.runtime.onLaunched.addListener(function() {
  *
  * @see http://developer.chrome.com/apps/app.runtime.html
  */
-window.chrome.app.runtime.onRestarted.addListener(function() {
+chrome.app.runtime.onRestarted.addListener(function() {
   runApp();
 });
 
@@ -23,9 +23,9 @@ window.chrome.app.runtime.onRestarted.addListener(function() {
  * @see http://developer.chrome.com/apps/app.window.html
  */
 function runApp() {
-  window.chrome.app.window.create(
+  chrome.app.window.create(
     'browser.html',
-    {'id': 'initialBrowserWindowID', 'state': 'maximized'},
+    {'id': 'initialBrowserWindowID'},
     function(newWindow) {
       // Do not inject meaningful window.newWindowEvent; browser will instead
       // load the homepage

diff --git a/samples/webview-samples/multi-tab-browser/manifest.json b/samples/webview-samples/multi-tab-browser/manifest.json
@@ -1,7 +1,7 @@
 {
   "manifest_version": 2,
   "name": "Multi-tabbed Browser",
-  "minimum_chrome_version": "24.0.1307.0",
+  "minimum_chrome_version": "35.0.0.0",
   "version": "0.7",
   "icons": {
     "16": "icon_16.png",

diff --git a/samples/webview-samples/new-window-user-agent/README.md b/samples/webview-samples/new-window-user-agent/README.md
@@ -10,16 +10,16 @@ API](https://developer.chrome.com/apps/tags/webview#method-setUserAgentOverride)
 for
 [webviews](http://developer.chrome.com/apps/app_external.html#webview). The
 app combines the [New Window
-Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/webview-samples/new-window)
+Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/new-window)
 and the [User Agent
-Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/webview-samples/user-agent)
+Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/user-agent)
 by supporting `Open link in new tab/window as...` via the [Context Menu
 API](https://developer.chrome.com/extensions/contextMenus) (see screenshot).
 
 ## Features
 
 * All features from the [New Window
-Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/webview-samples/new-window)
+Sample](https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/new-window)
 * Context menu entries for `Open link in new tab/window
   as Android/iPhone/Nokia Mobile/BlackBerry Playbook`
 

diff --git a/samples/webview-samples/new-window-user-agent/main.js b/samples/webview-samples/new-window-user-agent/main.js
@@ -4,7 +4,7 @@
  * @see http://developer.chrome.com/apps/app.runtime.html
  * @see http://developer.chrome.com/apps/app.window.html
  */
-window.chrome.app.runtime.onLaunched.addListener(function() {
+chrome.app.runtime.onLaunched.addListener(function() {
   runApp();
 });
 
@@ -13,7 +13,7 @@ window.chrome.app.runtime.onLaunched.addListener(function() {
  *
  * @see http://developer.chrome.com/apps/app.runtime.html
  */
-window.chrome.app.runtime.onRestarted.addListener(function() {
+chrome.app.runtime.onRestarted.addListener(function() {
   runApp();
 });
 
@@ -23,7 +23,7 @@ window.chrome.app.runtime.onRestarted.addListener(function() {
  * @see http://developer.chrome.com/apps/app.window.html
  */
 function runApp() {
-  window.chrome.app.window.create(
+  chrome.app.window.create(
     'browser.html',
     {'id': 'initialBrowserWindowID', 'state': 'maximized'},
     function(newWindow) {

diff --git a/samples/webview-samples/new-window/README.md b/samples/webview-samples/new-window/README.md
@@ -34,4 +34,4 @@ that identify a different window open a new window.
 
 
 ## Screenshot
-![screenshot](https://raw.github.com/mdittmer/chrome-app-samples/new-window/webview-samples/new-window/assets/screenshot_1280_800.png)
+![screenshot](/samples/webview-samples/new-window/assets/screenshot_1280_800.png)
diff --git a/samples/webview-samples/new-window/main.js b/samples/webview-samples/new-window/main.js
@@ -4,7 +4,7 @@
  * @see http://developer.chrome.com/apps/app.runtime.html
  * @see http://developer.chrome.com/apps/app.window.html
  */
-window.chrome.app.runtime.onLaunched.addListener(function() {
+chrome.app.runtime.onLaunched.addListener(function() {
   runApp();
 });
 
@@ -13,7 +13,7 @@ window.chrome.app.runtime.onLaunched.addListener(function() {
  *
  * @see http://developer.chrome.com/apps/app.runtime.html
  */
-window.chrome.app.runtime.onRestarted.addListener(function() {
+chrome.app.runtime.onRestarted.addListener(function() {
   runApp();
 });
 
@@ -23,7 +23,7 @@ window.chrome.app.runtime.onRestarted.addListener(function() {
  * @see http://developer.chrome.com/apps/app.window.html
  */
 function runApp() {
-  window.chrome.app.window.create(
+  chrome.app.window.create(
     'browser.html',
     {'id': 'initialBrowserWindowID', 'state': 'maximized'},
     function(newWindow) {

diff --git a/samples/webview-samples/shared-script/main.js b/samples/webview-samples/shared-script/main.js
@@ -4,7 +4,7 @@
  * @see http://developer.chrome.com/apps/app.runtime.html
  * @see http://developer.chrome.com/apps/app.window.html
  */
-window.chrome.app.runtime.onLaunched.addListener(function() {
+chrome.app.runtime.onLaunched.addListener(function() {
   runApp();
 });
 
@@ -13,7 +13,7 @@ window.chrome.app.runtime.onLaunched.addListener(function() {
  *
  * @see http://developer.chrome.com/apps/app.runtime.html
  */
-window.chrome.app.runtime.onRestarted.addListener(function() {
+chrome.app.runtime.onRestarted.addListener(function() {
   runApp();
 });
 
@@ -23,14 +23,14 @@ window.chrome.app.runtime.onRestarted.addListener(function() {
  * @see http://developer.chrome.com/apps/app.window.html
  */
 function runApp() {
-  window.chrome.app.window.create('correct_injection.html', {'id': 'goodWindowID'},
+  chrome.app.window.create('correct_injection.html', {'id': 'goodWindowID'},
     function(appGoodWindow) {
       var offset = 20;
       var badWindowOuterBounds = {
         'left': appGoodWindow.outerBounds.left + offset,
         'top': appGoodWindow.outerBounds.top + offset
       };
-      window.chrome.app.window.create('incorrect_injection.html', {'id': 'badWindowID', 'outerBounds': badWindowOuterBounds});
+      chrome.app.window.create('incorrect_injection.html', {'id': 'badWindowID', 'outerBounds': badWindowOuterBounds});
     }
   );
 }
diff --git a/samples/webview-samples/user-agent/README.md b/samples/webview-samples/user-agent/README.md
@@ -26,4 +26,4 @@ security and reliability of your application.
 
 
 ## Screenshot
-![screenshot](https://raw.github.com/mdittmer/chrome-app-samples/user-agent/webview-samples/user-agent/assets/screenshot_1280_800.png)
+![screenshot](/samples/webview-samples/user-agent/assets/screenshot_1280_800.png)
diff --git a/samples/webview-samples/user-agent/main.js b/samples/webview-samples/user-agent/main.js
@@ -4,7 +4,7 @@
  * @see http://developer.chrome.com/apps/app.runtime.html
  * @see http://developer.chrome.com/apps/app.window.html
  */
-window.chrome.app.runtime.onLaunched.addListener(function() {
+chrome.app.runtime.onLaunched.addListener(function() {
   runApp();
 });
 
@@ -13,7 +13,7 @@ window.chrome.app.runtime.onLaunched.addListener(function() {
  *
  * @see http://developer.chrome.com/apps/app.runtime.html
  */
-window.chrome.app.runtime.onRestarted.addListener(function() {
+chrome.app.runtime.onRestarted.addListener(function() {
   runApp();
 });
 
@@ -23,7 +23,7 @@ window.chrome.app.runtime.onRestarted.addListener(function() {
  * @see http://developer.chrome.com/apps/app.window.html
  */
 function runApp() {
-  window.chrome.app.window.create(
+  chrome.app.window.create(
       'browser.html',
       {'id': 'browserWinID', 'state': 'maximized'});
 }