Fixing the 'device_instance' being None in some partition places #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to make sure `add_partition` can't continue silently
…get device (#896) * disk layout: partprobe should be called and checked only for target device * disk layout: partprobe: removed unnecessary bash subprocess
|
Found the possible culprit: Added an exception to |
…e mount-checks got some rrro handling and non-block devices should no longer attempt to return a size
Torxed
referenced
this pull request
Jan 25, 2022
…get device (#896) * disk layout: partprobe should be called and checked only for target device * disk layout: partprobe: removed unnecessary bash subprocess
This was referenced Jan 25, 2022
|
We also had to change and make sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One minor issue was that
add_partitionwas defined to return-> None.Another issue might be uuid comparison using small/capital letters when comparing, so unified that.
Added a bunch of debugging and placed an exception in case
add_partitiondoesn't return anything at all.