Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation file #941

Merged
merged 8 commits into from
Feb 8, 2022
Merged

Conversation

erickisos
Copy link
Contributor

@erickisos erickisos commented Feb 5, 2022

Describe your PR

This is just the spanish translation for the archinstaller

Relates to: #893

@erickisos erickisos changed the title wip: add base.po for spanish Spanish translation file Feb 5, 2022
@erickisos erickisos marked this pull request as ready for review February 5, 2022 01:00
@svartkanin
Copy link
Collaborator

@erickisos I just raised an update for the nationalization #944, it's fixing some odd texts and adds some previously missed translations.
I would like to update your PR with my changes so we can get the latest clean version translated into spanish if that's okay with you?
It shouldn't cause any major issues, but some few texts might have to be retranslated

@svartkanin
Copy link
Collaborator

I just realized that I don't have any mighty power and can't push anything to this PR/branch but I'd like to help to resolve the updated texts if you like

@erickisos
Copy link
Contributor Author

It would be great! But I don't know how can I give you permissions to do that, let me check

@dylanmtaylor
Copy link
Contributor

I just realized that I don't have any mighty power and can't push anything to this PR/branch but I'd like to help to resolve the updated texts if you like

You can open a PR against his branch in his fork.

@Torxed
Copy link
Member

Torxed commented Feb 6, 2022

The easiest way is if @svartkanin forks your fork, and submits a patch to it, that you accept and then I accept this.

Upstream -> erickisos -> svartkanin
   PR <------- PR <----------|

@svartkanin
Copy link
Collaborator

Sounds good, I'll try to get that done today

@svartkanin
Copy link
Collaborator

@erickisos I raised a PR against your master that should include the changes

@Torxed
Copy link
Member

Torxed commented Feb 8, 2022

Looks like this is ready to go in? :)

@erickisos
Copy link
Contributor Author

Yessss, we are ready now!

@Torxed Torxed merged commit feffa69 into archlinux:master Feb 8, 2022
@Torxed
Copy link
Member

Torxed commented Feb 8, 2022

Thank you for this contribution! :D

@erickisos erickisos deleted the es-translation branch February 8, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants