Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arguments being initialized twice for tenants:seed command #611

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

morloderex
Copy link
Contributor

Laravel >= 8.32 introduced a new argument to the seed command see laravel/framework#36513.

This is causing our extended tenants:seed command to initialize the options and arguments twice which throws an exception because at the point we call the specifyParameters method in the constructor it has already instanciated the arguments once so the new class argument is already present.

This pr fixes that by removing our call to the specifyParameters method on the constructor sense it's already being called in the parent constructor anyway and the only thing we are really doing is specifying one additional option to the command anyway.

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #611 (4742fb8) into 3.x (192594c) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #611      +/-   ##
============================================
- Coverage     86.94%   86.92%   -0.03%     
  Complexity      366      366              
============================================
  Files           103      103              
  Lines          1088     1086       -2     
============================================
- Hits            946      944       -2     
  Misses          142      142              
Impacted Files Coverage Δ Complexity Δ
src/Commands/Seed.php 92.85% <ø> (-0.90%) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192594c...c50dcbc. Read the comment docs.

@stancl stancl merged commit 27e9fb4 into archtechx:3.x Mar 10, 2021
@stancl
Copy link
Member

stancl commented Mar 10, 2021

Thanks!

@morloderex morloderex deleted the 3.x branch March 10, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants