Install referenced schema in "npm:validate" task #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "npm:validate" task validates the repository's `package.json` npm manifest file against its JSON schema to catch any problems with its data format. In order to avoid duplication of content, JSON schemas may reference other schemas via the `$ref` keyword. The `package.json` schema was recently updated to share resources with the "base" configuration schema, which caused the validation to start failing: schema /tmp/package-json-schema-norSGPxlCR.json is invalid error: can't resolve reference https://json.schemastore.org/base.json#/definitions/license from id https://json.schemastore.org/package.json# task: Failed to run task "npm:validate": exit status 1 The solution is to configure the task to download that schema as well and also to provide its path to the avj-cli validator via a `-r` flag.
per1234
added
type: imperfection
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
npm:validatetask validates the repository'spackage.jsonnpm manifest file against its JSON schema to catch any problems with its data format.In order to avoid duplication of content, JSON schemas may reference other schemas via the
$refkeyword. Thepackage.jsonschema was recently updated to share resources with the "base" configuration schema, which caused the validation to start failing:https://github.com/arduino/setup-protoc/actions/runs/7728930562/job/21070931021#step:5:88
The solution is to configure the task to download that schema as well and also to provide its path to the avj-cli validator via a
-rflag.This is a sync from the upstream "template" asset: arduino/tooling-project-assets@c4393b0