Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add js_type config option (#59) #60

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Add js_type config option (#59) #60

merged 4 commits into from
Feb 14, 2024

Conversation

Thomva
Copy link
Contributor

@Thomva Thomva commented Sep 24, 2022

I have added a js_type to the config.

@Thomva Thomva mentioned this pull request Sep 24, 2022
@mrtimbrook
Copy link
Collaborator

Thanks for doing this. Is there a way we can work the type into the assets array so we're not setting the same type for all assets? It would need to support both array and string.

@mrtimbrook mrtimbrook closed this Jul 14, 2023
@Thomva
Copy link
Contributor Author

Thomva commented Jan 4, 2024

Hi, sorry for taking so long to respond. I have updated the code. It now checks if the js asset has a type, and if so, it uses it in the script tag. I have also updated the README. Can this PR be reopened, or do I create a new one?

@mrtimbrook mrtimbrook reopened this Feb 14, 2024
@mrtimbrook mrtimbrook merged commit 3080e73 into area17:1.x Feb 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants