Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLO-930 chore: fee error ui #1966

Merged
merged 1 commit into from
Mar 29, 2023
Merged

BLO-930 chore: fee error ui #1966

merged 1 commit into from
Mar 29, 2023

Conversation

simonheys
Copy link
Collaborator

@simonheys simonheys commented Mar 28, 2023 •
edited
Loading

Issue / feature description

Fee error states should match designs

Changes

  • add accordion theme with error style
  • implement for error states in fee estimation

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

Screenshot 2023-03-28 at 15 25 08

Screenshot 2023-03-28 at 15 24 54

@github-actions
Copy link

Builds for local testing

@github-actions
Copy link

Builds for local testing

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
1.9% 1.9% Duplication

@dhruvkelawala
Copy link
Contributor

This is not a chore. 😂

@simonheys simonheys merged commit d4d43f3 into develop Mar 29, 2023
@simonheys simonheys deleted the fix/BLO-930-fee-error-ui branch March 29, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluecco bluecco bluecco approved these changes

@diegodelrieu diegodelrieu diegodelrieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonheys @dhruvkelawala @bluecco @diegodelrieu