Add wallet_switchStarknetChain request method
#656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delaaxe
reviewed
May 23, 2022
| | { | ||
| type: "APPROVE_REQUEST_SWITCH_CUSTOM_NETWORK" | ||
| data: { actionHash: string } | ||
| } |
There was a problem hiding this comment.
this file is getting big - could be split up into smaller features files (for another PR)
packages/extension/src/ui/features/actions/AddNetworkScreen.tsx
Outdated
Show resolved
Hide resolved
delaaxe
approved these changes
May 23, 2022
| payload: { | ||
| id: string | ||
| name: string | ||
| chainId: string // A 0x-prefixed hexadecimal string |
There was a problem hiding this comment.
wondering if we could define a specific typescript type for the 0x-prefixed hex strings to check that is doesn't accept just any string, just a thought
There was a problem hiding this comment.
Currently we shouldn't do it because chainId for Mainnet is "SN_MAIN" and Goerli it's "SN_GOERLI". Let's see what other custom network implements. They might not go with hexadecimal standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.