Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reStartRecordingLive function #138

Merged
merged 12 commits into from
May 15, 2024
Merged

Conversation

fengcunhan
Copy link
Contributor

You can continues record after pause recording

Copy link
Contributor

@ZachNagengast ZachNagengast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, seems like there was the pause feature but was missing resume, suggested a couple changes for clarity.

Sources/WhisperKit/Core/AudioProcessor.swift Outdated Show resolved Hide resolved
Sources/WhisperKit/Core/AudioProcessor.swift Outdated Show resolved Hide resolved
Sources/WhisperKit/Core/AudioProcessor.swift Outdated Show resolved Hide resolved
Sources/WhisperKit/Core/AudioProcessor.swift Outdated Show resolved Hide resolved
cunhanfeng and others added 6 commits May 14, 2024 22:40
Co-authored-by: Zach Nagengast <zacharynagengast@gmail.com>
Co-authored-by: Zach Nagengast <zacharynagengast@gmail.com>
Co-authored-by: Zach Nagengast <zacharynagengast@gmail.com>
Co-authored-by: Zach Nagengast <zacharynagengast@gmail.com>
@fengcunhan
Copy link
Contributor Author

This is great, seems like there was the pause feature but was missing resume, suggested a couple changes for clarity.

Yes,i will use your suggestion.Thank you for review my code.

Co-authored-by: Zach Nagengast <zacharynagengast@gmail.com>
@ZachNagengast ZachNagengast self-requested a review May 15, 2024 21:19
Copy link
Contributor

@ZachNagengast ZachNagengast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for contributing this @fengcunhan

@ZachNagengast ZachNagengast merged commit 984de54 into argmaxinc:main May 15, 2024
15 checks passed
@fengcunhan
Copy link
Contributor Author

Looks great! Thanks for contributing this @fengcunhan

You are welcome.Thanks for your patient of review my begainer level swift code.This project is awesome,i like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants