This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
E2E tests should use application-controller serviceaccount, rather than applicationset-controller serviceaccount #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an applicationset-controller serviceaccount
jgwest
force-pushed
the
fix-service-account-432
branch
from
85e965a
to
a3c36c7
Compare
wtam2018
approved these changes
Dec 30, 2021
ishitasequeira
pushed a commit
to ishitasequeira/applicationset
that referenced
this pull request
Jan 11, 2022
…an applicationset-controller serviceaccount (argoproj#434)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks for a service account named
*application-controller*, and uses that to create an Argo CD cluster secret for the cluster creation tests. Previously it usedapplicationset-controller, but that didn't work because that serviceaccount is too unprivileged.Fixes #432