This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
feat: make webhook address configurable #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkilchhofer
approved these changes
Jan 6, 2022
|
Addresses my comment in #445 (comment) |
5 tasks
wtam2018
approved these changes
Jan 10, 2022
ishitasequeira
pushed a commit
to ishitasequeira/applicationset
that referenced
this pull request
Jan 11, 2022
* feat: make webhook address configurable * do not hard exit when failed to create a webhook handler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the webhook address is hardcoded to ":7000". This PR introduces the below changes:
--webhook-addrflag to make the webhook address configurable.Example:
./dist/argocd-applicationset --webhook-addr=":9999" --logformat=jsonref: https://github.com/argoproj-labs/applicationset/pull/341/files#r779156282