This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
Remove Argo CD integration, and update Argo CD dependencies #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan West <jonwest@redhat.com>
jgwest
force-pushed
the
remove-argo-cd-integration-and-update-deps
branch
from
6f2c313
to
e594609
Compare
3 tasks
ishitasequeira
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
LGTM!
nit: Do we want to update the go version to 1.17.6 in github/workflows/image.yaml?
crenshaw-dev
suggested changes
Feb 16, 2022
| @@ -34,19 +43,6 @@ The `manifests/install.yaml` file contains the Kubernetes manifests required to | |||
| - RoleBinding to bind the ServiceAccount and Role | |||
|
|
|||
|
|
|||
| ### B) Install ApplicationSet and Argo CD together | |||
There was a problem hiding this comment.
C below should be changed to B.
| sigs.k8s.io/yaml v1.3.0 | ||
| ) | ||
|
|
||
| require ( |
There was a problem hiding this comment.
Just for my own knowledge: is this just a pinning mechanism for transient dependencies, in order to get (relatively) deterministic builds?
hack/generate-manifests.sh
Outdated
| @@ -42,11 +42,5 @@ cd ${SRCROOT}/manifests/namespace-install && ${KUSTOMIZE} build . >> ${TEMPFILE} | |||
| mv ${TEMPFILE} ${SRCROOT}/manifests/install.yaml | |||
| cd ${SRCROOT} && chmod 644 manifests/install.yaml | |||
|
|
|||
| # Verify that the 'install-with-argo-cd.yaml' is targetting the expected Argo CD version | |||
| # Verify that the GitHub actions is targetting the expected Argo CD version | |||
There was a problem hiding this comment.
Suggested change
| # Verify that the GitHub actions is targetting the expected Argo CD version | |
| # Verify that the GitHub actions are targeting the expected Argo CD version |
wtam2018
reviewed
Feb 25, 2022
Signed-off-by: William Tam <wtam@redhat.com>
Signed-off-by: William Tam <wtam@redhat.com>
Signed-off-by: William Tam <wtam@redhat.com>
update go-version to 1.17.6 in `publish` job
Signed-off-by: William Tam <wtam@redhat.com>
Signed-off-by: William Tam <email.wtam@gmail.com>
wtam2018
approved these changes
Feb 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: