feat(kustomize): support envsubst in commonAnnotations and commonLabels #11345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #11345 +/- ##
==========================================
+ Coverage 47.98% 48.00% +0.01%
==========================================
Files 246 246
Lines 42225 42234 +9
==========================================
+ Hits 20263 20275 +12
+ Misses 19939 19937 -2
+ Partials 2023 2022 -1
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
crenshaw-dev
changed the title
AndrewChubatiuk
force-pushed
the
kustomize-params-envsubst
branch
7 times, most recently
from
7282890
to
4915d47
Compare
AndrewChubatiuk
force-pushed
the
kustomize-params-envsubst
branch
2 times, most recently
from
af03c96
to
5589e91
Compare
|
Oren from Komodor, Would love to see this added ❤️ |
AndrewChubatiuk
force-pushed
the
kustomize-params-envsubst
branch
2 times, most recently
from
5ec1fe5
to
77b4c4b
Compare
crenshaw-dev
changed the title
AndrewChubatiuk
force-pushed
the
kustomize-params-envsubst
branch
2 times, most recently
from
bbf9274
to
906231d
Compare
AndrewChubatiuk
force-pushed
the
kustomize-params-envsubst
branch
from
906231d
to
8567523
Compare
crenshaw-dev
requested changes
Mar 10, 2023
There was a problem hiding this comment.
Thanks for your patience @AndrewChubatiuk! Would you mind documenting the new field here? https://github.com/argoproj/argo-cd/blob/master/docs/operator-manual/application.yaml
added 2 commits
March 11, 2023 00:32
Signed-off-by: Andrii Chubatiuk <andrew.chubatiuk@motional.com>
Signed-off-by: Andrii Chubatiuk <andrew.chubatiuk@motional.com>
AndrewChubatiuk
force-pushed
the
kustomize-params-envsubst
branch
from
b13e5ea
to
a5a3b14
Compare
Added this new field to application.yaml file |
…vsubst Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…vsubst Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
approved these changes
Mar 22, 2023
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…ls (argoproj#11345) * support envsubst in kustomize commonAnnotations and commonLabels Signed-off-by: Andrii Chubatiuk <andrew.chubatiuk@motional.com> * added description for new parameter Signed-off-by: Andrii Chubatiuk <andrew.chubatiuk@motional.com> --------- Signed-off-by: Andrii Chubatiuk <andrew.chubatiuk@motional.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Andrii Chubatiuk <andrew.chubatiuk@motional.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #11333 PR