Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use http constants instead of string #12334

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

Fish-pro
Copy link
Contributor

@Fish-pro Fish-pro commented Feb 8, 2023

Signed-off-by: Fish-pro zechun.chen@daocloud.io

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 47.63% // Head: 47.63% // No change to project coverage 👍

Coverage data is based on head (68e5719) compared to base (7bff6c1).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12334   +/-   ##
=======================================
  Coverage   47.63%   47.63%           
=======================================
  Files         246      246           
  Lines       41801    41801           
=======================================
  Hits        19911    19911           
  Misses      19897    19897           
  Partials     1993     1993           
Impacted Files Coverage Δ
applicationset/services/scm_provider/gitea.go 69.15% <0.00%> (ø)
applicationset/webhook/webhook.go 65.71% <0.00%> (ø)
util/helm/client.go 47.51% <50.00%> (ø)
...cationset/services/scm_provider/bitbucket_cloud.go 73.64% <100.00%> (ø)
applicationset/services/scm_provider/github.go 81.25% <100.00%> (ø)
util/dex/dex.go 57.50% <100.00%> (ø)
util/webhook/webhook.go 68.28% <100.00%> (ø)
util/settings/settings.go 49.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Fish-pro
Copy link
Contributor Author

Fish-pro commented Feb 9, 2023

@terrytangyuan
It has already been approved, why hasn't it been merged yet? Request for guidance

@terrytangyuan
Copy link
Member

You'll need the actual approvals from approvers in OWNERS file.

@Fish-pro
Copy link
Contributor Author

Fish-pro commented Feb 9, 2023

You'll need the actual approvals from approvers in OWNERS file.

@terrytangyuan Thanks, I got it

@Fish-pro
Copy link
Contributor Author

Fish-pro commented Feb 9, 2023

/cc @crenshaw-dev

Copy link
Contributor

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Fish-pro!

@crenshaw-dev crenshaw-dev merged commit c85902c into argoproj:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants