-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use http constants instead of string #12334
Conversation
Codecov ReportBase: 47.63% // Head: 47.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #12334 +/- ##
=======================================
Coverage 47.63% 47.63%
=======================================
Files 246 246
Lines 41801 41801
=======================================
Hits 19911 19911
Misses 19897 19897
Partials 1993 1993
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@terrytangyuan |
You'll need the actual approvals from approvers in OWNERS file. |
@terrytangyuan Thanks, I got it |
/cc @crenshaw-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Fish-pro!
Signed-off-by: Fish-pro zechun.chen@daocloud.io
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: