-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace github.com/ghodss/yaml
with sigs.k8s.io/yaml
#13292
Conversation
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #13292 +/- ##
==========================================
- Coverage 49.01% 49.01% -0.01%
==========================================
Files 247 247
Lines 42685 42685
==========================================
- Hits 20924 20921 -3
- Misses 19645 19647 +2
- Partials 2116 2117 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Looks great! It would also be good to update the notification-engine as well. |
@blakepettersson Please also review argoproj/notifications-engine#175. I'll update this PR once that has been merged. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Juneezee!
@Juneezee once the notifications-engine fix is in, we can open another PR to bump the notifications-engine version. :-) |
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Reference: argoproj/argo-cd#13292 (comment) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Reference: argoproj/argo-cd#13292 (comment) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
In the same vein as argoproj#13292, since `github.com/ghodss/yaml` is no longer maintained. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* feat: values can be either a string or a map Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Allow viewing and editing values Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix golang lint Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix codegen make build green Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Add special cases for handling nil/empty string. strip newline at end of generated yaml. fix unittests Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Add tests. Fix e2e marshalJSON Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix codegen. make codegen and make codegen-local give different results to me Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Update helm_test.go Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Fix UI - validate input Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * change implementation; introduce valuesObject instead of values Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * More generated files. Fix tests Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Fix eslint Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * chore: make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: use sigs.k8s.io/yaml In the same vein as #13292, since `github.com/ghodss/yaml` is no longer maintained. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: compact values Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: make manifests Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: add to helm user guide Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: remove any deprecation mentions Remove any mentions that `Values` is deprecated, for now. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: add assertion verify that valuesobject overrides values by checking the number of replicas. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: remove assertion This wasn't meant to be in there, was a typo. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: minor nit fix Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* self-service from event * chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml (#175) At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Reference: argoproj/argo-cd#13292 (comment) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * feat: Adding new PagerDuty integration based on Events API v2 (#105) Signed-off-by: Eric Tendian <erictendian@gmail.com> * self-service from event * self-service from event * self-service from event * self-service from event * self-service from event * clean up factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * better caching * better caching * refactor Signed-off-by: zachaller <zachaller@users.noreply.github.com> * unused Signed-off-by: zachaller <zachaller@users.noreply.github.com> * lint Signed-off-by: zachaller <zachaller@users.noreply.github.com> * bump ci Signed-off-by: zachaller <zachaller@users.noreply.github.com> * small fixes Signed-off-by: zachaller <zachaller@users.noreply.github.com> * rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * change log line Signed-off-by: zachaller <zachaller@users.noreply.github.com> * update tests Signed-off-by: zachaller <zachaller@users.noreply.github.com> * continue on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> * continue on errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add godoc Signed-off-by: zachaller <zachaller@users.noreply.github.com> * continue on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix error by going back to non namespace support Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix log Signed-off-by: zachaller <zachaller@users.noreply.github.com> * improve log on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Signed-off-by: Eric Tendian <erictendian@gmail.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com> Co-authored-by: May Zhang <may_zhang@intuit.com> Co-authored-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Eric Tendian <erictendian@gmail.com>
…proj#13292) At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
… (argoproj#11538) * feat: values can be either a string or a map Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Allow viewing and editing values Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix golang lint Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix codegen make build green Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Add special cases for handling nil/empty string. strip newline at end of generated yaml. fix unittests Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Add tests. Fix e2e marshalJSON Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix codegen. make codegen and make codegen-local give different results to me Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Update helm_test.go Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Fix UI - validate input Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * change implementation; introduce valuesObject instead of values Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * More generated files. Fix tests Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Fix eslint Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * chore: make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: use sigs.k8s.io/yaml In the same vein as argoproj#13292, since `github.com/ghodss/yaml` is no longer maintained. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: compact values Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: make manifests Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: add to helm user guide Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: remove any deprecation mentions Remove any mentions that `Values` is deprecated, for now. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: add assertion verify that valuesobject overrides values by checking the number of replicas. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: remove assertion This wasn't meant to be in there, was a typo. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: minor nit fix Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
… (argoproj#11538) * feat: values can be either a string or a map Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Allow viewing and editing values Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix golang lint Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix codegen make build green Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Add special cases for handling nil/empty string. strip newline at end of generated yaml. fix unittests Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Add tests. Fix e2e marshalJSON Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix codegen. make codegen and make codegen-local give different results to me Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Update helm_test.go Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Fix UI - validate input Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * change implementation; introduce valuesObject instead of values Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * More generated files. Fix tests Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Fix eslint Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * chore: make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: use sigs.k8s.io/yaml In the same vein as argoproj#13292, since `github.com/ghodss/yaml` is no longer maintained. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: compact values Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: make manifests Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: add to helm user guide Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: remove any deprecation mentions Remove any mentions that `Values` is deprecated, for now. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: add assertion verify that valuesobject overrides values by checking the number of replicas. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: remove assertion This wasn't meant to be in there, was a typo. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: minor nit fix Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
The
github.com/ghodss/yaml
package is no longer actively maintained.sigs.k8s.io/yaml
is a permanent fork ofgithub.com/ghodss/yaml
. It is actively maintained by Kubernetes SIG, and also widely used in K8s projects.The notable change is that
github.com/ghodss/yaml
usesgopkg.in/yaml.v2 v2.2.2
, butsigs.k8s.io/yaml
usesgopkg.in/yaml.v2 v2.4.0
. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.I also ran
go mod tidy
.Checklist: