Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a button to show parameter details (#12183) #16871

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

Tchoupinax
Copy link
Contributor

@Tchoupinax Tchoupinax commented Jan 15, 2024

Hello,

This work aims to not display parameter details by default in the history view. We might have hundreds of parameters and the original view to see old versions is not pratical due to the scroll. The issue is already opened here: #12183

Closes #12183

I would ask some feedback about the way to do it. Please find a record of the feature below.

Currently, the index in rollback query param is used to determine which history loads. That's said, with this new behavior the index won't be useful anymore: we load basics information for each history and display additional parameters details on demand.

I'm asking if the design is good to load all metadata or if I add to continue to ask for a click before loading data. What do you think?

Edited overview
https://github.com/user-attachments/assets/a1fbe606-8334-4a24-b729-f866645300b8

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@Tchoupinax Tchoupinax requested a review from a team as a code owner January 15, 2024 20:03
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. But could you please change how button is look. I think it is not super intuitive that it is a button

Copy link

bunnyshell bot commented Sep 3, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Sep 3, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@Tchoupinax Tchoupinax changed the title feat: WIP add a button to show parameter details (#12183) feat: add a button to show parameter details (#12183) Sep 3, 2024
@Tchoupinax
Copy link
Contributor Author

Hello @pasha-codefresh I rebased and I used argocd default buttons style, tell me what you think!

Signed-off-by: Tchoupinax <corentinfiloche@hotmail.fr>
Signed-off-by: Tchoupinax <corentinfiloche@hotmail.fr>
Signed-off-by: Tchoupinax <corentinfiloche@hotmail.fr>
Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how the button looks, and I think the "Click to see source details" should be also a similar button, maybe "show/hide source details" and "show/hide parameter details" for the button you have already added.

@Tchoupinax
Copy link
Contributor Author

I agree with the idea! Do you think it makes sense to do it in this PR?

@reggie-k
Copy link
Member

reggie-k commented Sep 8, 2024

No, this can be done separately. LGTM!

@pasha-codefresh pasha-codefresh merged commit be90cc0 into argoproj:master Sep 8, 2024
23 of 24 checks passed
@marcin-wicha
Copy link

Hey! This change is a problem when you want to find a specific hash to rollback to. After the change just CMD+F to find the hash doesn't work anymore and we need to manually open all of the details and look for the hash. This is very suboptimal.

From the code it looks like this behavior is not customizable, so right now we're either stuck with a soboptimal experience or rolling-back to previous ArgoCD release.

@Tchoupinax
Copy link
Contributor Author

Hello @marcin-wicha,
Thank you for your report I made the merge request to fix this. The button "Click to see details" was pretty confusing. I hope I did not add another regression.
Now, the first part is loaded by default (revision, author, etc) and only the params table is hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History and Rollback : Don't display details of last deployed revision when opening the screen.
4 participants