fix(appset): keep reconciling even when params error occurred

[similark]

Fixes #16832

This PR addresses a issue within the ApplicationSet controller in ArgoCD.
Currently, when encountering an error while generating a set of parameters for an application, the controller logs the error, then logs the desired applications (which IMO still expected to be generated), but fails to actually generate any applications.
Specifically, the issue arises when the controller encounters an error in generating only one set of parameters, causing a halt in application generation despite successful generation attempts for other set of parameters.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 49.25%. Comparing base (2b6b9bf) to head (8be10b5).
Report is 6 commits behind head on master.

❗ Current head 8be10b5 differs from pull request most recent head 997f5c7. Consider uploading reports for the commit 997f5c7 to get more accurate results

Files	Patch %	Lines
...cationset/controllers/applicationset_controller.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #17062      +/-   ##
==========================================
- Coverage   49.45%   49.25%   -0.20%     
==========================================
  Files         273      274       +1     
  Lines       48662    48139     -523     
==========================================
- Hits        24066    23713     -353     
+ Misses      22235    22081     -154     
+ Partials     2361     2345      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[todaywasawesome]

I think this is the correct behavior thought I do worry about situations where an error should stop creation and when it doesn't the other apps get created incorrectly.

But appsets are super powerful and have to be treated that way anyway so I think it's overall correct.

[similark]

I think this is the correct behavior thought I do worry about situations where an error should stop creation and when it doesn't the other apps get created incorrectly.

@todaywasawesome can you give an example for such scenario?
As I see it, each set of parameters is completely independent to the other(s), and needs to be treated as such. When a generator fails to render/patch/apply-patch an application it shouldn't affect the rest.

[blakepettersson]

@similark can you provide E2E tests and unit tests for this issue?

[similark]

@similark can you provide E2E tests and unit tests for this issue?
@blakepettersson
Done

[ishitasequeira]

Overall PR looks good.