Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): admin settings rbac can has inconsistency among project resources #17805

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

hanxiaop
Copy link
Contributor

Fixes #17563

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: xiaopeng <hanxiaop8@outlook.com>
@hanxiaop hanxiaop requested a review from a team as a code owner April 11, 2024 03:33
@hanxiaop hanxiaop changed the title Fix(cli): admin settings rbac can has inconsistency among project resources fix(cli): admin settings rbac can has inconsistency among project resources Apr 11, 2024
Signed-off-by: xiaopeng <hanxiaop8@outlook.com>
@reggie-k
Copy link
Member

reggie-k commented Sep 2, 2024

Please run lint

@kencochrane
Copy link

@hanxiaop thanks for fixing that, it looks like the linter found some errors that you will need to fix.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the test and PR can be merged

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this lints properly, it's ready to go : D

@todaywasawesome todaywasawesome enabled auto-merge (squash) September 4, 2024 14:57
@hanxiaop
Copy link
Contributor Author

hanxiaop commented Sep 5, 2024

@pasha-codefresh Thank you for helping me fix the lint issues. However, resolving the lint didn’t pass the tests, as you can see https://github.com/argoproj/argo-cd/actions/runs/10704179817/job/29676741607?pr=17805. Due to the changes in #19264, I need to revise the if/else condition to ensure it passes the test cases, rather than just addressing the lint issue. For convenience, I will remove your commits and redo the changes myself, but I really appreciate your help!

@hanxiaop
Copy link
Contributor Author

hanxiaop commented Sep 5, 2024

Thank you all for the help with this PR! I appreciate the feedbacks.

Signed-off-by: xiaopeng <hanxiaop8@outlook.com>
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.78%. Comparing base (63b6565) to head (f36d824).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #17805   +/-   ##
=======================================
  Coverage   55.77%   55.78%           
=======================================
  Files         320      320           
  Lines       44206    44206           
=======================================
+ Hits        24656    24660    +4     
- Misses      16988    16994    +6     
+ Partials     2562     2552   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdsoumya gdsoumya merged commit aa2bafd into argoproj:master Sep 5, 2024
27 of 28 checks passed
@pasha-codefresh
Copy link
Member

@hanxiaop thank you, and amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: argocd admin settings rbac can doesn't report permissions correctly
9 participants