-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): admin settings rbac can
has inconsistency among project resources
#17805
Conversation
Signed-off-by: xiaopeng <hanxiaop8@outlook.com>
admin settings rbac can
has inconsistency among project resourcesadmin settings rbac can
has inconsistency among project resources
Signed-off-by: xiaopeng <hanxiaop8@outlook.com>
5d99029
to
9003304
Compare
Please run lint |
@hanxiaop thanks for fixing that, it looks like the linter found some errors that you will need to fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please fix the test and PR can be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that this lints properly, it's ready to go : D
@pasha-codefresh Thank you for helping me fix the lint issues. However, resolving the lint didn’t pass the tests, as you can see https://github.com/argoproj/argo-cd/actions/runs/10704179817/job/29676741607?pr=17805. Due to the changes in #19264, I need to revise the if/else condition to ensure it passes the test cases, rather than just addressing the lint issue. For convenience, I will remove your commits and redo the changes myself, but I really appreciate your help! |
7b7cf06
to
df7ce7c
Compare
Thank you all for the help with this PR! I appreciate the feedbacks. |
Signed-off-by: xiaopeng <hanxiaop8@outlook.com>
df7ce7c
to
f36d824
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17805 +/- ##
=======================================
Coverage 55.77% 55.78%
=======================================
Files 320 320
Lines 44206 44206
=======================================
+ Hits 24656 24660 +4
- Misses 16988 16994 +6
+ Partials 2562 2552 -10 ☔ View full report in Codecov by Sentry. |
@hanxiaop thank you, and amazing work! |
Fixes #17563
Checklist: