Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): argo checkbox #18793

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix(ui): argo checkbox #18793

merged 1 commit into from
Jun 25, 2024

Conversation

ymktmk
Copy link
Contributor

@ymktmk ymktmk commented Jun 24, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Fixed the safari input checkbox CSS that was broken

Before

スクリーンショット 2024-06-24 18 58 15

After

スクリーンショット 2024-06-24 18 59 00

@ymktmk ymktmk requested a review from a team as a code owner June 24, 2024 09:56
Copy link

bunnyshell bot commented Jun 24, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Jun 24, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: ymktmk <ymktmk.tt@gmail.com>
@ymktmk ymktmk changed the title fix: argo checkbox fix(ui): argo checkbox Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (c5d5cdb) to head (bc71c17).
Report is 1159 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18793      +/-   ##
==========================================
- Coverage   49.51%   47.61%   -1.90%     
==========================================
  Files         270      337      +67     
  Lines       47500    47012     -488     
==========================================
- Hits        23519    22387    -1132     
- Misses      21669    21759      +90     
- Partials     2312     2866     +554     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ashutosh16 ashutosh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashutosh16 ashutosh16 enabled auto-merge (squash) June 25, 2024 02:23
@ashutosh16 ashutosh16 merged commit ba0ee5d into argoproj:master Jun 25, 2024
40 checks passed
ggjulio pushed a commit to ggjulio/argo-cd that referenced this pull request Jul 21, 2024
Signed-off-by: ymktmk <ymktmk.tt@gmail.com>
jsolana pushed a commit to jsolana/argo-cd that referenced this pull request Jul 24, 2024
Signed-off-by: ymktmk <ymktmk.tt@gmail.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants