Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appset): allow for shorthand git refs in git generators #15427 #19783

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

rumstead
Copy link
Member

@rumstead rumstead commented Sep 4, 2024

fixes #15427

The GitHub webhook sends the full branch ref eg, refs/heads/env/dev. There is code to parse out the revision which will correctly parse out env/dev. However, in the appset, if someone uses the shorthand ref, env/dev it will get parsed out incorrectly to dev.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead rumstead requested a review from a team as a code owner September 4, 2024 15:21
Copy link

bunnyshell bot commented Sep 4, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Sep 4, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@rumstead rumstead changed the title fix(appset): allow for shorthand git refs in git generators fix(appset): allow for shorthand git refs in git generators #15427 Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.78%. Comparing base (63b6565) to head (b11fc27).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...t-controller/commands/applicationset_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19783      +/-   ##
==========================================
+ Coverage   55.77%   55.78%   +0.01%     
==========================================
  Files         320      320              
  Lines       44206    44203       -3     
==========================================
+ Hits        24656    24659       +3     
- Misses      16988    16993       +5     
+ Partials     2562     2551      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall change looks good!!

Copy link
Member

@wanghong230 wanghong230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the proper test!

@gdsoumya gdsoumya merged commit 01874d6 into argoproj:master Sep 5, 2024
27 of 28 checks passed
@rumstead rumstead deleted the fix/appset-webhook branch September 5, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook not refreshing applications
4 participants