Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path error in docs for argo ui contributing #5898

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

reginapizza
Copy link
Contributor

Small error in the path in this part of the docs I added, after going through this process myself I realized my error here. yarn add command should be run from the ui folder.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Regina Scott <rescott@redhat.com>
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #5898 (4d21b90) into master (6f5f87b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5898   +/-   ##
=======================================
  Coverage   40.89%   40.89%           
=======================================
  Files         147      147           
  Lines       19633    19633           
=======================================
  Hits         8028     8028           
  Misses      10500    10500           
  Partials     1105     1105           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5f87b...4d21b90. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jannfis jannfis merged commit 9590dc9 into argoproj:master Mar 30, 2021
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Signed-off-by: Regina Scott <rescott@redhat.com>
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
@jgwest jgwest removed the needs-verification PR requires pre-release verification label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants