Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use podname in failure podName instead of ID. Fixes #10124 #10268

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

isubasinghe
Copy link
Member

Signed-off-by: Isitha Subasinghe isitha@pipekit.io

Fixes #10124

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
@isubasinghe isubasinghe marked this pull request as ready for review December 21, 2022 09:17
@ognjen-it
Copy link

Hey, can someone do CR? :)

@alexec alexec merged commit 2607867 into argoproj:master Jan 5, 2023
reddymh pushed a commit to reddymh/argo-workflows that referenced this pull request Jan 31, 2023
… (argoproj#10268)

Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
Signed-off-by: Rajshekar Reddy <reddymh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong podName in workflow.status
3 participants